[GitHub] [hive] odraese commented on a change in pull request #944: [Hive-22760] Adding Clock based eviction strategy.

[GitBox <gi...@apache.org>]

odraese commented on a change in pull request #944: [Hive-22760] Adding Clock based eviction strategy.
URL: https://github.com/apache/hive/pull/944#discussion_r395852162
 
 

 ##########
 File path: common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
 ##########
 @@ -4187,6 +4188,8 @@ private static void populateLlapDaemonVarsSet(Set<String> llapDaemonVarsSetLocal
          "partitions and tables) for reporting."),
     LLAP_USE_LRFU("hive.llap.io.use.lrfu", true,
         "Whether ORC low-level cache should use LRFU cache policy instead of default (FIFO)."),
+    LLAP_IO_CACHE_STRATEGY("hive.llap.io.replacement.strategy", "lrfu", new StringSet("fifo", "clock", "lrfu"),
+        "Cache replacement strategy used by low-level (default to LRFU)."),
 
 Review comment:
   used by low-level what? 
   would rewrite to "Replacement strategy for IO/data cache"

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org