You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by jo...@gmail.com on 2010/04/16 02:22:47 UTC

Re: Keep user-agent when performing a proxy request (issue852045)

small points.


http://codereview.appspot.com/852045/diff/1/6
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java
(right):

http://codereview.appspot.com/852045/diff/1/6#newcode155
java/gadgets/src/main/java/org/apache/shindig/gadgets/render/ProxyRenderer.java:155:
userAgent = userAgent + " " + myIdent;
maybe semicolon, then ident?

http://codereview.appspot.com/852045/diff/1/5
File
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpGadgetContext.java
(right):

http://codereview.appspot.com/852045/diff/1/5#newcode171
java/gadgets/src/main/java/org/apache/shindig/gadgets/servlet/HttpGadgetContext.java:171:
String userAgent = request.getHeader("User-Agent");
may as well just expose getHeader() instead.

http://codereview.appspot.com/852045/show