[GitHub] [incubator-pekko] pjfanning commented on a diff in pull request #638: =remote Clean up unused field.

["pjfanning (via GitHub)" <gi...@apache.org>]

pjfanning commented on code in PR #638:
URL: https://github.com/apache/incubator-pekko/pull/638#discussion_r1319990130


##########
remote/src/main/scala/org/apache/pekko/remote/transport/netty/NettyTransport.scala:
##########
@@ -184,8 +182,6 @@ class NettyTransportSettings(config: Config) {
     case value => value.toInt
   }
 
-  val SslSettings: Option[SSLSettings] = if (EnableSsl) Some(new SSLSettings(config.getConfig("security"))) else None

Review Comment:
   strictly speaking: we can't remove a public field without deprecating it first



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org