[GitHub] [incubator-mxnet] reminisce commented on a change in pull request #15942: Refines NDArray indexing and adds numpy ndarray indexing [DO NOT MERGE YET]

[GitBox <gi...@apache.org>]

reminisce commented on a change in pull request #15942: Refines NDArray indexing and adds numpy ndarray indexing [DO NOT MERGE YET]
URL: https://github.com/apache/incubator-mxnet/pull/15942#discussion_r315348399
 
 

 ##########
 File path: python/mxnet/ndarray/numpy/_op.py
 ##########
 @@ -27,7 +27,8 @@
 from ..ndarray import NDArray
 
 __all__ = ['zeros', 'ones', 'add', 'subtract', 'multiply', 'divide', 'mod', 'power', 'tensordot',
-           'linspace', 'expand_dims', 'tile', 'arange', 'split', 'concatenate', 'stack']
+           'linspace', 'expand_dims', 'tile', 'arange', 'split', 'concatenate', 'stack', 'full',
+           'slice_assign_scalar', 'slice_assign']
 
 Review comment:
   We should only expose numpy ops, while these two are not.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services