You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/04/21 08:36:08 UTC
[GitHub] [apisix] zuiyangqingzhou opened a new pull request, #6897: Fix/document limit conn
zuiyangqingzhou opened a new pull request, #6897:
URL: https://github.com/apache/apisix/pull/6897
### Description
<!-- Please include a summary of the change and which issue is fixed. -->
<!-- Please also include relevant motivation and context. -->
Fixes https://github.com/apache/apisix/blob/master/docs/zh/latest/plugins/limit-conn.md#L32-L35
### Checklist
- [ ] I have explained the need for this PR and the problem it solves
- [ ] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change
- [ ] I have updated the documentation to reflect this change
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] zuiyangqingzhou commented on a diff in pull request #6897: docs: update "limit-conn" plugin docs
Posted by GitBox <gi...@apache.org>.
zuiyangqingzhou commented on code in PR #6897:
URL: https://github.com/apache/apisix/pull/6897#discussion_r855724623
##########
docs/zh/latest/plugins/limit-conn.md:
##########
@@ -29,10 +29,10 @@ title: limit-conn
| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 |
| ------------------ | ------- | -------- | ------ | ----------------------------------------------------------------------------------------- |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| conn | integer | required | | conn > 0 | 允许的最大并发请求数。超过 `conn` 的限制、但是低于 `conn` + `burst` 的请求，将被延迟处理。 |
-| burst | integer | required | | burst >= 0 | 允许被延迟处理的并发请求数。 |
-| default_conn_delay | number | required | | default_conn_delay > 0 | 默认的典型连接（或请求）的处理延迟时间。 |
-| only_use_default_delay | boolean | optional | false | [true,false] | 延迟时间的严格模式。 如果设置为`true`的话，将会严格按照设置的时间来进行延迟 |
+| conn | integer | 必须 | | conn > 0 | 允许的最大并发请求数。超过 `conn` 的限制、但是低于 `conn` + `burst` 的请求，将被延迟处理。 |
+| burst | integer | 必须 | | burst >= 0 | 允许被延迟处理的并发请求数。 |
+| default_conn_delay | number | 必须 | | default_conn_delay > 0 | 默认的典型连接（或请求）的处理延迟时间。 |
+| only_use_default_delay | boolean | 可选 | false | [true,false] | 延迟时间的严格模式。 如果设置为`true`的话，将会严格按照设置的时间来进行延迟 |
Review Comment:
> Please change `required` to `是` and `optional` to`否`. Please modify all 'required' columns in this article.
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6897: docs: update "limit-conn" plugin docs
Posted by GitBox <gi...@apache.org>.
spacewander merged PR #6897:
URL: https://github.com/apache/apisix/pull/6897
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] hf400159 commented on a diff in pull request #6897: docs: update "limit-conn" plugin docs
Posted by GitBox <gi...@apache.org>.
hf400159 commented on code in PR #6897:
URL: https://github.com/apache/apisix/pull/6897#discussion_r855693135
##########
docs/zh/latest/plugins/limit-conn.md:
##########
@@ -29,10 +29,10 @@ title: limit-conn
| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 |
| ------------------ | ------- | -------- | ------ | ----------------------------------------------------------------------------------------- |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| conn | integer | required | | conn > 0 | 允许的最大并发请求数。超过 `conn` 的限制、但是低于 `conn` + `burst` 的请求，将被延迟处理。 |
-| burst | integer | required | | burst >= 0 | 允许被延迟处理的并发请求数。 |
-| default_conn_delay | number | required | | default_conn_delay > 0 | 默认的典型连接（或请求）的处理延迟时间。 |
-| only_use_default_delay | boolean | optional | false | [true,false] | 延迟时间的严格模式。 如果设置为`true`的话，将会严格按照设置的时间来进行延迟 |
+| conn | integer | 必须 | | conn > 0 | 允许的最大并发请求数。超过 `conn` 的限制、但是低于 `conn` + `burst` 的请求，将被延迟处理。 |
+| burst | integer | 必须 | | burst >= 0 | 允许被延迟处理的并发请求数。 |
+| default_conn_delay | number | 必须 | | default_conn_delay > 0 | 默认的典型连接（或请求）的处理延迟时间。 |
+| only_use_default_delay | boolean | 可选 | false | [true,false] | 延迟时间的严格模式。 如果设置为`true`的话，将会严格按照设置的时间来进行延迟 |
Review Comment:
```suggestion
| only_use_default_delay | boolean | 否 | false | [true,false] | 延迟时间的严格模式。 如果设置为`true`的话，将会严格按照设置的时间来进行延迟 |
```
##########
docs/zh/latest/plugins/limit-conn.md:
##########
@@ -29,10 +29,10 @@ title: limit-conn
| 名称 | 类型 | 必选项 | 默认值 | 有效值 | 描述 |
| ------------------ | ------- | -------- | ------ | ----------------------------------------------------------------------------------------- |----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
-| conn | integer | required | | conn > 0 | 允许的最大并发请求数。超过 `conn` 的限制、但是低于 `conn` + `burst` 的请求，将被延迟处理。 |
-| burst | integer | required | | burst >= 0 | 允许被延迟处理的并发请求数。 |
-| default_conn_delay | number | required | | default_conn_delay > 0 | 默认的典型连接（或请求）的处理延迟时间。 |
-| only_use_default_delay | boolean | optional | false | [true,false] | 延迟时间的严格模式。 如果设置为`true`的话，将会严格按照设置的时间来进行延迟 |
+| conn | integer | 必须 | | conn > 0 | 允许的最大并发请求数。超过 `conn` 的限制、但是低于 `conn` + `burst` 的请求，将被延迟处理。 |
Review Comment:
```suggestion
| conn | integer | 是 | | conn > 0 | 允许的最大并发请求数。超过 `conn` 的限制、但是低于 `conn` + `burst` 的请求，将被延迟处理。 |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org