You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2021/08/30 08:58:00 UTC

[jira] [Commented] (IMPALA-10822) Allow multiple group returns for LDAP search bind authentication group search

    [ https://issues.apache.org/jira/browse/IMPALA-10822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17406636#comment-17406636 ] 

ASF subversion and git services commented on IMPALA-10822:
----------------------------------------------------------

Commit ce47a9c9cccb621ead33c3810555be94280eecf4 in impala's branch refs/heads/master from Tamas Mate
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=ce47a9c ]

IMPALA-10822: Allow multiple group returns for LDAP Search

This commit updates the LdapSearch method to allow multiple results by
refactoring the condition that checks the number of results. The
condition was removed from the method and it is now the caller's
responsibility to decide if the returned number of results are correct.

The change was necessary, because the LdapSearch method was written
too generally and used for both user and group searches. While it is
reasonable to fail authentication requests where the LDAP Search
returns more than one user this should not be the case for group
searches, as a user can be part of multiple groups matching the search
criteria.

Testing:
 - Updated the unit test to cover this use-case

Change-Id: I27eaf717985207e36d4fa47a2af757d06544474e
Reviewed-on: http://gerrit.cloudera.org:8080/17794
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>


> Allow multiple group returns for LDAP search bind authentication group search
> -----------------------------------------------------------------------------
>
>                 Key: IMPALA-10822
>                 URL: https://issues.apache.org/jira/browse/IMPALA-10822
>             Project: IMPALA
>          Issue Type: Improvement
>          Components: Backend, Security
>            Reporter: Tamas Mate
>            Assignee: Tamas Mate
>            Priority: Major
>
> Group search uses the same LdapSearch method that the user which has a condition that only one result should be returned, otherwise the authentication is ambiguous. However, this condition is too restrictive for group searches and multiple search results should be allowed.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org