You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org> on 2009/06/29 16:37:47 UTC

[jira] Created: (QPID-1961) widen viewMessages(int From, int To) and getMessageCount() AMQQueueMBean methods to use Long values

widen viewMessages(int From, int To) and getMessageCount() AMQQueueMBean methods to use Long values
---------------------------------------------------------------------------------------------------

                 Key: QPID-1961
                 URL: https://issues.apache.org/jira/browse/QPID-1961
             Project: Qpid
          Issue Type: Sub-task
          Components: Java Broker, Java Management : JMX Console
    Affects Versions: M4, M3, M2.1, 0.5
            Reporter: Robbie Gemmell
            Assignee: Robbie Gemmell
            Priority: Minor


The viewMessages() operation is inherently limited to viewing the first 2^31 undelivered messages on the queue at any given time due to its use of int parameters. Equally, getMessageCount() returns an int value. However, the SimpleAMQQueue implementation is not limited to 2^31 messages and so there is potential that not all messages can be viewed.

This should be rectified by increasing the parameter range to Long. The viewMessages() implementation will then be limited to viewing ANY 2^31 messages on the queue as the TabularData OpenData result sets used to support generic JMX clients are also fixed in size by an int index.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Assigned: (QPID-1961) widen viewMessages(int From, int To) AMQQueueMBean method to use Long values

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell reassigned QPID-1961:
------------------------------------

    Assignee: Aidan Skinner  (was: Robbie Gemmell)

Hi Aidan, can you review this change please, thanks.

> widen viewMessages(int From, int To) AMQQueueMBean method to use Long values
> ----------------------------------------------------------------------------
>
>                 Key: QPID-1961
>                 URL: https://issues.apache.org/jira/browse/QPID-1961
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker, Java Management : JMX Console
>    Affects Versions: M2.1, M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Aidan Skinner
>            Priority: Minor
>             Fix For: 0.6
>
>
> The viewMessages() operation is inherently limited to viewing the first 2^31 undelivered messages on the queue at any given time due to its use of int parameters. Equally, getMessageCount() returns an int value. However, the SimpleAMQQueue implementation is not limited to 2^31 messages and so there is potential that not all messages can be viewed.
> This should be rectified by increasing the parameter range to Long. The viewMessages() implementation will then be limited to viewing ANY 2^31 messages on the queue as the TabularData OpenData result sets used to support generic JMX clients are also fixed in size by an int index.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-1961) widen viewMessages(int From, int To) AMQQueueMBean method to use Long values

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-1961:
---------------------------------

    Fix Version/s: 0.6
          Summary: widen viewMessages(int From, int To) AMQQueueMBean method to use Long values  (was: widen viewMessages(int From, int To) and getMessageCount() AMQQueueMBean methods to use Long values)

changing getMessageCount() from an Integer return type to Long will break compatibility with the JMX CLI. As filling a queue with 2^31 messages involves an extreme amount of memory it is not a typical scenario at present and so changing this will be postponed until future alterations to the management API necessitate a general break in compatibility.

> widen viewMessages(int From, int To) AMQQueueMBean method to use Long values
> ----------------------------------------------------------------------------
>
>                 Key: QPID-1961
>                 URL: https://issues.apache.org/jira/browse/QPID-1961
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker, Java Management : JMX Console
>    Affects Versions: M2.1, M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 0.6
>
>
> The viewMessages() operation is inherently limited to viewing the first 2^31 undelivered messages on the queue at any given time due to its use of int parameters. Equally, getMessageCount() returns an int value. However, the SimpleAMQQueue implementation is not limited to 2^31 messages and so there is potential that not all messages can be viewed.
> This should be rectified by increasing the parameter range to Long. The viewMessages() implementation will then be limited to viewing ANY 2^31 messages on the queue as the TabularData OpenData result sets used to support generic JMX clients are also fixed in size by an int index.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Resolved: (QPID-1961) widen viewMessages(int From, int To) AMQQueueMBean method to use Long values

Posted by "Aidan Skinner (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Aidan Skinner resolved QPID-1961.
---------------------------------

    Resolution: Fixed

> widen viewMessages(int From, int To) AMQQueueMBean method to use Long values
> ----------------------------------------------------------------------------
>
>                 Key: QPID-1961
>                 URL: https://issues.apache.org/jira/browse/QPID-1961
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker, Java Management : JMX Console
>    Affects Versions: M2.1, M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Aidan Skinner
>            Priority: Minor
>             Fix For: 0.6
>
>
> The viewMessages() operation is inherently limited to viewing the first 2^31 undelivered messages on the queue at any given time due to its use of int parameters. Equally, getMessageCount() returns an int value. However, the SimpleAMQQueue implementation is not limited to 2^31 messages and so there is potential that not all messages can be viewed.
> This should be rectified by increasing the parameter range to Long. The viewMessages() implementation will then be limited to viewing ANY 2^31 messages on the queue as the TabularData OpenData result sets used to support generic JMX clients are also fixed in size by an int index.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org


[jira] Updated: (QPID-1961) widen viewMessages(int From, int To) AMQQueueMBean method to use Long values

Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
     [ https://issues.apache.org/jira/browse/QPID-1961?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robbie Gemmell updated QPID-1961:
---------------------------------

    Status: Ready To Review  (was: In Progress)

> widen viewMessages(int From, int To) AMQQueueMBean method to use Long values
> ----------------------------------------------------------------------------
>
>                 Key: QPID-1961
>                 URL: https://issues.apache.org/jira/browse/QPID-1961
>             Project: Qpid
>          Issue Type: Sub-task
>          Components: Java Broker, Java Management : JMX Console
>    Affects Versions: M2.1, M3, M4, 0.5
>            Reporter: Robbie Gemmell
>            Assignee: Robbie Gemmell
>            Priority: Minor
>             Fix For: 0.6
>
>
> The viewMessages() operation is inherently limited to viewing the first 2^31 undelivered messages on the queue at any given time due to its use of int parameters. Equally, getMessageCount() returns an int value. However, the SimpleAMQQueue implementation is not limited to 2^31 messages and so there is potential that not all messages can be viewed.
> This should be rectified by increasing the parameter range to Long. The viewMessages() implementation will then be limited to viewing ANY 2^31 messages on the queue as the TabularData OpenData result sets used to support generic JMX clients are also fixed in size by an int index.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org