You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2016/02/17 10:54:53 UTC
[GitHub] flink pull request: [FLINK-3426] Fixed JobManagerLeader[Re]Electio...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/1651
[FLINK-3426] Fixed JobManagerLeader[Re]ElectionTest.testleaderElectio…
…n onWindows
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 3426_test_failure_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1651.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1651
----
commit 84b0a7c08b6c1976f8a040c20d2fc9b1c603ae3f
Author: zentol <s....@web.de>
Date: 2016-02-17T09:54:07Z
[FLINK-3426] Fixed JobManagerLeader[Re]ElectionTest.testleaderElection onWindows
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3426] Fixed JobManagerLeader[Re]Electio...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1651#issuecomment-187705967
Alright, thanks for the update @zentol. I'll test the changes with HDFS and if they pass, I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3426] Fixed JobManagerLeader[Re]Electio...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1651
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3426] Fixed JobManagerLeader[Re]Electio...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1651#issuecomment-187715909
Worked with Hadoop 2.7.1.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3426] Fixed JobManagerLeader[Re]Electio...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the pull request:
https://github.com/apache/flink/pull/1651#issuecomment-187616129
I agree with @StephanEwen that we cannot be sure that the user does not choose a different filesystem than the local one. Thus, I guess replacing `File(basePath).toURI` by `Path(basePath).toUri` is a good idea.
Have you tested your changes with different `basePath` types @zentol?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3426] Fixed JobManagerLeader[Re]Electio...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1651#issuecomment-187699668
I've only tried it with local paths.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3426] Fixed JobManagerLeader[Re]Electio...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the pull request:
https://github.com/apache/flink/pull/1651#issuecomment-185155443
how about ``` new Path(basePath).toUri()``` instead of ```new File(basePath)toUri()```?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3426] Fixed JobManagerLeader[Re]Electio...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1651#issuecomment-185152853
Are we sure that this always only uses local file systems? This change would break HDFS or S3 URIs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---