You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by haosdent huang <ha...@gmail.com> on 2016/02/12 07:41:23 UTC
Review Request 43518: Speed up
MasterMaintenanceTest.EnterMaintenanceMode.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/
-----------------------------------------------------------
Review request for mesos and Ben Mahler.
Bugs: MESOS-4168
https://issues.apache.org/jira/browse/MESOS-4168
Repository: mesos
Description
-------
Speed up MasterMaintenanceTest.EnterMaintenanceMode.
Diffs
-----
src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
Diff: https://reviews.apache.org/r/43518/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 43518: Speed up
MasterMaintenanceTest.EnterMaintenanceMode.
Posted by haosdent huang <ha...@gmail.com>.
> On Feb. 18, 2016, 7:34 p.m., Joseph Wu wrote:
> > Confirmed speedup (on OSX) and doesn't appear to be flaky (1500 iterations).
Thank you very much for you review, could you help check it again?
- haosdent
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/#review119698
-----------------------------------------------------------
On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43518/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 1:46 a.m.)
>
>
> Review request for mesos, Ben Mahler and Joseph Wu.
>
>
> Bugs: MESOS-4168
> https://issues.apache.org/jira/browse/MESOS-4168
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up MasterMaintenanceTest.EnterMaintenanceMode.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
>
> Diff: https://reviews.apache.org/r/43518/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43518: Speed up
MasterMaintenanceTest.EnterMaintenanceMode.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/#review119698
-----------------------------------------------------------
Fix it, then Ship it!
Confirmed speedup (on OSX) and doesn't appear to be flaky (1500 iterations).
src/tests/master_maintenance_tests.cpp (lines 61 - 66)
<https://reviews.apache.org/r/43518/#comment181034>
Instead of importing these default constants, use `SlaveFlags::executor_shutdown_grace_period` and `MasterFlags::allocation_interval`.
You'll need to slightly modify the `StartMaster` and `StartSlave` calls.
i.e.
```
// NOTE: We don't use `StartMaster()` because we need to access these flags.
master::Flags flags = CreateMasterFlags();
```
src/tests/master_maintenance_tests.cpp (line 693)
<https://reviews.apache.org/r/43518/#comment181035>
Once you change the above, this will look like `Clock::advance(slaveFlags.executor_shutdown_grace_period);`.
- Joseph Wu
On Feb. 11, 2016, 10:41 p.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43518/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 10:41 p.m.)
>
>
> Review request for mesos and Ben Mahler.
>
>
> Bugs: MESOS-4168
> https://issues.apache.org/jira/browse/MESOS-4168
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up MasterMaintenanceTest.EnterMaintenanceMode.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
>
> Diff: https://reviews.apache.org/r/43518/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43518: Speed up
MasterMaintenanceTest.EnterMaintenanceMode.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/#review120567
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Feb. 19, 2016, 1:46 a.m., haosdent huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43518/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2016, 1:46 a.m.)
>
>
> Review request for mesos, Ben Mahler and Joseph Wu.
>
>
> Bugs: MESOS-4168
> https://issues.apache.org/jira/browse/MESOS-4168
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Speed up MasterMaintenanceTest.EnterMaintenanceMode.
>
>
> Diffs
> -----
>
> src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
>
> Diff: https://reviews.apache.org/r/43518/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> haosdent huang
>
>
Re: Review Request 43518: Speed up
MasterMaintenanceTest.EnterMaintenanceMode.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 1:46 a.m.)
Review request for mesos, Ben Mahler and Joseph Wu.
Changes
-------
Rebase
Bugs: MESOS-4168
https://issues.apache.org/jira/browse/MESOS-4168
Repository: mesos
Description
-------
Speed up MasterMaintenanceTest.EnterMaintenanceMode.
Diffs (updated)
-----
src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
Diff: https://reviews.apache.org/r/43518/diff/
Testing
-------
Thanks,
haosdent huang
Re: Review Request 43518: Speed up
MasterMaintenanceTest.EnterMaintenanceMode.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43518/
-----------------------------------------------------------
(Updated Feb. 19, 2016, 1:44 a.m.)
Review request for mesos, Ben Mahler and Joseph Wu.
Changes
-------
Address @kaysoky's comments.
Bugs: MESOS-4168
https://issues.apache.org/jira/browse/MESOS-4168
Repository: mesos
Description
-------
Speed up MasterMaintenanceTest.EnterMaintenanceMode.
Diffs (updated)
-----
3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp 162bdfb6c4f5a6b108761ebccd9b77e672f6dd87
3rdparty/libprocess/3rdparty/stout/tests/strings_tests.cpp 7eed0f3d08cd52a07c46b6ad194496186ac205b7
3rdparty/libprocess/include/process/gmock.hpp 15b982f101994ce717ceeb29a1bd0028bd2ba940
3rdparty/libprocess/src/help.cpp bac980ddec98b34bdfd786b03d0691fefb93f45a
3rdparty/libprocess/src/tests/http_tests.cpp 4337e6028a3a6e5279793c7c6f73bb9a4f60cb0a
CHANGELOG 004978fffe221e2f430f3f5517dc31d692ad23a5
configure.ac b045d3c68a2d440bed4d1b3e6ab21a1bbe063517
docs/authentication.md c7649bb279312e3183d8c977811d12121208f9f8
docs/configuration.md b04e873009dc783cc50eb02a459f0587d020ad23
docs/endpoints/master/create-volumes.md 1e8fd20dc842defc0a3d22e4f19ddbe3a685cb53
docs/endpoints/master/destroy-volumes.md 7209a7cf788116a29eb6235d3a8a0225253c04f7
docs/endpoints/master/reserve.md a71eb8e1800acea0890510ba8d988a7f09047778
docs/endpoints/master/state.json.md dad5627eea9481fdbfd91966062c813be7e0f586
docs/endpoints/master/state.md 7fdd5f72eb621fd37e9ec32fc73f1bf50bd5d488
docs/endpoints/master/unreserve.md 5de7734f86bc61583f06df3a7c02646bf02d01e0
docs/endpoints/slave/state.json.md 0a31159079cf28cd5b24b85064c1a7b9edc8cb65
docs/endpoints/slave/state.md 1077f697e5190dfd91391be541aec196597ae966
docs/high-availability-framework-guide.md 0d9c483985d61b512339f50f395f9360de034e2d
docs/home.md 07214b927c112d7a180507ae03245892455fd757
docs/images/log-architecture.png 34c57f19387868486882e6fa8bd5d2362113c952
docs/images/log-cluster.png 62042d2811dd21bd7b7301f140a9d474c4e8fd07
docs/maintenance.md 4d24ec680f3245b12b99e4bb6440ae5aab473460
docs/multiple-disk.md ab2e7e84398fda4abdae1bdd5daebe78b1e075b3
docs/network-monitoring.md 57b859e9292dc22613e235710312d1a33f58e0c0
docs/operational-guide.md a4d6710a8a3a4cde10fdccad332e3d539246ec83
docs/persistent-volume.md 2a794a572ff930aa1f95706b89fef9243be627de
docs/replicated-log-internals.md 4f379a3ff4e957a486fa13d721f4b66333aea6b3
docs/reservation.md 41321d436d3a90475bcce551dd9af2adeb2e68d6
include/mesos/docker/spec.hpp 5fb6647cc02aa64fa9305b1ec6db9d6d81caf5f7
include/mesos/mesos.proto 804794642d7d8a7df2ce3829f2f9b332a080a9ce
include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54
src/CMakeLists.txt 5cf0ec8c475839ad8717192a37f01546cbcccd7a
src/Makefile.am 27aec37524aa33211e0ca4594e127ebb4279e9b0
src/common/command_utils.hpp 525f9c1c37b74f7e4cc71fdc8d52944226998ddc
src/common/command_utils.cpp 3f1d7f3694a1688ec7c035234e99f2f823bddaee
src/docker/spec.cpp 07c0b87ee1a3b6981adfc96f5a7add6f625374c1
src/java/src/org/apache/mesos/SchedulerDriver.java bf866f5ebece2505eaa27bf39a1382cd1a2a069a
src/linux/systemd.hpp 6b240b9cc2fe559d111a4235e70f00e07f3d4495
src/linux/systemd.cpp e120d2ceffe6bb400859f2a132f02a99f561f856
src/master/http.cpp 248e3d432a756c767fc00ee224101d82c417068c
src/master/master.hpp 2f2ad2ada508e1923bf995ab124367a3b082b572
src/slave/containerizer/composing.hpp f3eebd19bc9e6b3b8a969a2ad967b3e2909e0ee4
src/slave/containerizer/composing.cpp 15d059f0bbda4e8cb93c65c09327dde1e34d3e7b
src/slave/containerizer/docker.hpp 4d703813de9757a9a26694c9984902e85ba3380b
src/slave/containerizer/docker.cpp 0303208083f1ebd9f9df51178fd91ee4c763f61c
src/slave/containerizer/mesos/containerizer.hpp 3ef6a6752a6656e97be9f48bd4d2d060d1f9cb46
src/slave/containerizer/mesos/containerizer.cpp 129406abdff715e321f683911e404c46676b6daf
src/slave/containerizer/mesos/isolators/network/port_mapping.hpp 0fe2f486eb733acf738c1c61fc44f820d7401afc
src/slave/containerizer/mesos/isolators/network/port_mapping.cpp 134b6c759b769cf335539e49eff817973c7f96a4
src/slave/containerizer/mesos/provisioner/appc/fetcher.hpp 373c7d4c0c7c4e35ca568f37e52915549798ee32
src/slave/containerizer/mesos/provisioner/appc/fetcher.cpp e12a6f27866b6362191ea4dafe8bf818b33cd9e3
src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 811c24b43f7aec9db406dd521770c6cd82097c92
src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp c980e445742d7e219ca7436b179af9d1ac93fff9
src/slave/containerizer/mesos/provisioner/docker/message.hpp f57f42f1a223f3125b5f0da6bad3effa182dba9e
src/slave/containerizer/mesos/provisioner/docker/message.proto c93c7a92ec152bd9747a70392adfe6a0e863e839
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp 137af502a66e6a65773c00eaacbe392576376284
src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp f391a943551792c8edf5759d9491fda33116f2b4
src/slave/containerizer/mesos/provisioner/docker/puller.hpp 5b2d72c22fcbcc379b4901607cf3eb682de66206
src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp 377da0c647db198a023c1631930637ed3df2188d
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 2ba6b10a269705ecd1d085ceec07d8d8c1bf2560
src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp bccbac11113357cf942446604e6cf5d16c3d594b
src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 3fcf1471a035e35a2cac22442655ad65a84a9793
src/slave/containerizer/mesos/provisioner/docker/store.cpp 12a39060a0aaf8f7afda77cbffd783e134994d51
src/slave/flags.hpp 54c1a69d8777f417cdd8f73ce638447d9951ab61
src/slave/flags.cpp 855812e9f7cb4b96d4297f4bd5ac5de7f1d3c39a
src/slave/http.cpp a18085ea020d0d6c39f23213e11af75a02eedb7e
src/slave/main.cpp e3a4d13ddaeb89ba01c9b2ddfc72c37934f753eb
src/tests/common/command_utils_tests.cpp c91a7f38263e4c8352ec56f79070baec2b1cb06f
src/tests/container_logger_tests.cpp 6e2b8c1b80d4b49a1042c53945c223785d0d4a3f
src/tests/containerizer/docker_containerizer_tests.cpp 8541a9a3d2f40cd6e78ff8fba474da214017937a
src/tests/containerizer/port_mapping_tests.cpp 983a63333be160aefe5a32acb6111bb3c85230ec
src/tests/containerizer/provisioner_docker_tests.cpp 4db6793a21abbb7ea4de0d0fca0431237d38d013
src/tests/fetcher_cache_tests.cpp f9c48f5d938c2601cb8f826029d6969d676ab98e
src/tests/group_tests.cpp af530f32fac47801a2cd0d941f3aa9196d448bd2
src/tests/master_contender_detector_tests.cpp 255ab8119a04b55bb4f1b61dee19c4be64499376
src/tests/master_maintenance_tests.cpp b98eedec388813ee795dd83ccc5ff27338209475
src/tests/resources_tests.cpp 96864c3945729fe33be8b243b9c826fb12e90eff
src/tests/zookeeper_tests.cpp 6bde10b9ae9a644d3506abb285786200dc2fbe94
src/v1/values.cpp 58ea9875804bf0287855a1e9855855e5e54de4c4
src/zookeeper/group.hpp 2003b60574e471c0dc08b8abf5f170df02f91f5b
src/zookeeper/group.cpp 7aa95a7b7eafe0a2c49dc077b3a4abd688e5d8e8
src/zookeeper/zookeeper.hpp 9191df50dd5b601491a86584f7184a31a6151ca5
Diff: https://reviews.apache.org/r/43518/diff/
Testing
-------
Thanks,
haosdent huang