[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #2760: ARTEMIS-2420 Adding support for DLA/DLQ prefix for wildcard addresses

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #2760: ARTEMIS-2420 Adding support for DLA/DLQ prefix for wildcard addresses
URL: https://github.com/apache/activemq-artemis/pull/2760#discussion_r305110265
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/management/impl/ActiveMQServerControlImpl.java
 ##########
 @@ -2635,6 +2635,9 @@ public String getAddressSettingsAsJSON(final String address) throws Exception {
       if (addressSettings.getDeadLetterAddress() != null) {
          settings.add("DLA", addressSettings.getDeadLetterAddress().toString());
       }
+      if (addressSettings.getDeadLetterAddressPrefix() != null) {
+         settings.add("DLAPrefix", addressSettings.getDeadLetterAddressPrefix().toString());
 
 Review comment:
   Should we avoid proliferating acronymn and use deadLetterAddressPrefix instead. Similar to expiryAddress. Is then clearer going forwards
   
   And in line with xml based configuration which isnt acronymd

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services