You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/06/21 08:29:40 UTC
[GitHub] [servicecomb-service-center] codecov-io commented on issue #561:
Abstract synchronous data structure
codecov-io commented on issue #561: Abstract synchronous data structure
URL: https://github.com/apache/servicecomb-service-center/pull/561#issuecomment-504340879
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/561?src=pr&el=h1) Report
> Merging [#561](https://codecov.io/gh/apache/servicecomb-service-center/pull/561?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/8415d947043db721d5f2cc32862d965c6fa6a047?src=pr&el=desc) will **decrease** coverage by `0.04%`.
> The diff coverage is `60.62%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/561?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
- Coverage 58.39% 58.35% -0.05%
==========================================
Files 201 201
Lines 15326 15450 +124
==========================================
+ Hits 8950 9016 +66
- Misses 5751 5797 +46
- Partials 625 637 +12
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/561?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/plugins/servicecenter/service.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci9zZXJ2aWNlLmdv) | `100% <100%> (ø)` | :arrow_up: |
| [syncer/plugins/servicecenter/instance.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci9pbnN0YW5jZS5nbw==) | `100% <100%> (ø)` | :arrow_up: |
| [syncer/plugins/servicecenter/servicecenter.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci9zZXJ2aWNlY2VudGVyLmdv) | `88.88% <100%> (ø)` | :arrow_up: |
| [syncer/servicecenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc3luYy5nbw==) | `80.95% <50%> (+11.56%)` | :arrow_up: |
| [syncer/plugins/servicecenter/transform.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c3luY2VyL3BsdWdpbnMvc2VydmljZWNlbnRlci90cmFuc2Zvcm0uZ28=) | `54.74% <54.88%> (-25.26%)` | :arrow_down: |
| [syncer/servicecenter/exclude.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvZXhjbHVkZS5nbw==) | `78.26% <70.58%> (-21.74%)` | :arrow_down: |
| [syncer/servicecenter/servicecenter.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc2VydmljZWNlbnRlci5nbw==) | `86.36% <78.94%> (-8.64%)` | :arrow_down: |
| [syncer/pkg/utils/addr.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy91dGlscy9hZGRyLmdv) | `63.63% <0%> (-9.1%)` | :arrow_down: |
| [syncer/pkg/syssig/signal.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy9zeXNzaWcvc2lnbmFsLmdv) | `64.51% <0%> (-3.23%)` | :arrow_down: |
| [scctl/pkg/plugin/diagnose/compare\_holder.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree#diff-c2NjdGwvcGtnL3BsdWdpbi9kaWFnbm9zZS9jb21wYXJlX2hvbGRlci5nbw==) | `94.87% <0%> (-1.29%)` | :arrow_down: |
| ... and [7 more](https://codecov.io/gh/apache/servicecomb-service-center/pull/561/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/561?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/561?src=pr&el=footer). Last update [8415d94...d3619e1](https://codecov.io/gh/apache/servicecomb-service-center/pull/561?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services