[jira] [Commented] (LUCENE-10531) Mark testLukeCanBeLaunched @Nightly test and make a dedicated Github CI workflow for it

["Tomoko Uchida (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/LUCENE-10531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17529194#comment-17529194 ] 

Tomoko Uchida commented on LUCENE-10531:
----------------------------------------

It shouldn't be slow at least on a physical machine (on VMs, we observed it can be slow (~1min) maybe because of the cpu/memory budgets assigned to the VM?). Meanwhile, I feel like it shouldn't be included in the mandatory tests suite since it's unlikely to be affected by the changes in other modules - I'd prefer to catch the launching problems on nightly CI runs.

> Mark testLukeCanBeLaunched @Nightly test and make a dedicated Github CI workflow for it
> ---------------------------------------------------------------------------------------
>
>                 Key: LUCENE-10531
>                 URL: https://issues.apache.org/jira/browse/LUCENE-10531
>             Project: Lucene - Core
>          Issue Type: Task
>          Components: general/test
>            Reporter: Tomoko Uchida
>            Priority: Minor
>
> We are going to allow running the test on Xvfb (a virtual display that speaks X protocol) in [LUCENE-10528], this tweak is available only on Linux.
> I'm just guessing but it could confuse or bother also Mac and Windows users (we can't know what window manager developers are using); it may be better to make it opt-in by marking it as slow tests. 
> Instead, I think we can enable a dedicated Github actions workflow for the distribution test that is triggered only when the related files are changed. Besides Linux, we could run it both on Mac and Windows which most users run the app on - it'd be slow, but if we limit the scope of the test I suppose it works functionally just fine (I'm running actions workflows on mac and windows elsewhere).
> To make it "slow test", we could add the same {{@Slow}} annotation as the {{test-framework}} to the distribution tests, for consistency.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org