You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by jinossy <gi...@git.apache.org> on 2016/01/11 05:48:00 UTC
[GitHub] tajo pull request: TAJO-2048: QueryMaster and TajoWorker should su...
GitHub user jinossy opened a pull request:
https://github.com/apache/tajo/pull/936
TAJO-2048: QueryMaster and TajoWorker should support the exception propagation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jinossy/tajo TAJO-2048
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tajo/pull/936.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #936
----
commit 1c725cf071247d04b59bfe73f2e28adcfa489be3
Author: Jinho Kim <jh...@apache.org>
Date: 2016-01-11T04:46:14Z
TAJO-2048: QueryMaster and TajoWorker should support the exception propagation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2048: QueryMaster and TajoWorker should su...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/936#issuecomment-173812292
+1 ship it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2048: QueryMaster and TajoWorker should su...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on the pull request:
https://github.com/apache/tajo/pull/936#issuecomment-173394473
Hi @jinossy, thanks for your work. It looks good overall.
I left a couple of comments. Please consider them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2048: QueryMaster and TajoWorker should su...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/936#discussion_r50335860
--- Diff: tajo-core/src/main/java/org/apache/tajo/master/TajoMasterClientService.java ---
@@ -505,6 +503,11 @@ public GetQueryStatusResponse getQueryStatus(RpcController controller, GetQueryS
builder.setFinishTime(queryInfo.getFinishTime());
} else {
builder.setFinishTime(System.currentTimeMillis());
+
+ if(!StringUtils.isEmpty(queryInfo.getLastMessage())) {
+ builder.setErrorMessage(queryInfo.getLastMessage());
+ }
+ builder.setState(OK);
--- End diff --
It seems duplicate code to set the query state.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2048: QueryMaster and TajoWorker should su...
Posted by jinossy <gi...@git.apache.org>.
Github user jinossy commented on a diff in the pull request:
https://github.com/apache/tajo/pull/936#discussion_r50494584
--- Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java ---
@@ -1415,8 +1434,9 @@ public StageState transition(Stage stage, StageEvent stageEvent) {
stage.abort(StageState.KILLED);
return StageState.KILLED;
} else {
- LOG.error("Invalid State " + stage.getSynchronizedState() + " State");
- stage.abort(StageState.ERROR);
+ TajoInternalError error = new TajoInternalError("Invalid State " + stage.getSynchronizedState() + " State");
--- End diff --
@jihoonson
this else clause seems to never be executed. I will remove this code block for clarify
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2048: QueryMaster and TajoWorker should su...
Posted by jihoonson <gi...@git.apache.org>.
Github user jihoonson commented on a diff in the pull request:
https://github.com/apache/tajo/pull/936#discussion_r50334735
--- Diff: tajo-core/src/main/java/org/apache/tajo/querymaster/Stage.java ---
@@ -1415,8 +1434,9 @@ public StageState transition(Stage stage, StageEvent stageEvent) {
stage.abort(StageState.KILLED);
return StageState.KILLED;
} else {
- LOG.error("Invalid State " + stage.getSynchronizedState() + " State");
- stage.abort(StageState.ERROR);
+ TajoInternalError error = new TajoInternalError("Invalid State " + stage.getSynchronizedState() + " State");
--- End diff --
I wonder when this else clause can be executed. Would you explain some details?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tajo pull request: TAJO-2048: QueryMaster and TajoWorker should su...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/tajo/pull/936
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---