You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/01/19 15:57:36 UTC

[GitHub] [superset] ad-m opened a new pull request #18089: fix(docs): load correctly image for "Create New Chart"

ad-m opened a new pull request #18089:
URL: https://github.com/apache/superset/pull/18089


   ### SUMMARY
   
   Image reference is invalid. Filename include is addiction "v". See https://github.com/apache/superset/blob/master/docs/static/images/create_pivot_v2.png . 
   
   File `/images/create_pivot_2.png` does not exist, but exist `/images/create_pivot_v2.png`.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Before: 
   ![obraz](https://user-images.githubusercontent.com/3618479/150167162-d953963f-cb96-4059-ae81-050589fb6636.png)
   
   See also at https://superset.apache.org/docs/creating-charts-dashboards/exploring-data 
   
   ### TESTING INSTRUCTIONS
   
   Build frontend & vist `/creating-charts-dashboards/exploring-data` page
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue: no
   - [ ] Required feature flags: no
   - [ ] Changes UI: no
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351)): no
     - [ ] Migration is atomic, supports rollback & is backwards-compatible: N/A
     - [ ] Confirm DB migration upgrade and downgrade tested: N/A
     - [ ] Runtime estimates and downtime expectations provided: N/A
   - [ ] Introduces new feature or API: no
   - [ ] Removes existing feature or API: no
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] ad-m commented on pull request #18089: fix(docs): load correctly image for "Create New Chart"

Posted by GitBox <gi...@apache.org>.
ad-m commented on pull request #18089:
URL: https://github.com/apache/superset/pull/18089#issuecomment-1017516018


   @kgabryje I believe you might be interested in that PR too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [superset] kgabryje merged pull request #18089: fix(docs): load correctly image for "Create New Chart"

Posted by GitBox <gi...@apache.org>.
kgabryje merged pull request #18089:
URL: https://github.com/apache/superset/pull/18089


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org