You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cxf.apache.org by "Evaristo Wychoski Benfatti (JIRA)" <ji...@apache.org> on 2017/11/13 18:32:00 UTC

[jira] [Comment Edited] (CXF-7545) Problem to generate WADL when a implementation of generic type is used

    [ https://issues.apache.org/jira/browse/CXF-7545?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16249946#comment-16249946 ] 

Evaristo Wychoski Benfatti edited comment on CXF-7545 at 11/13/17 6:31 PM:
---------------------------------------------------------------------------

This file {{cxf/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ResourceUtils.java}} also has simillar logic that must be taken into account to fix.

{code:java}
                       // Line 699 intead of this
-                      if (type == Object.class && !(genericType instanceof Class)) {
                       // using the following
+                     if (type == Object.class && !(genericType instanceof Class)
+                                      || (genericType instanceof TypeVariable)) {
{code}



was (Author: evaristowb):
This file {{ cxf/rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/ResourceUtils.java}} also has simillar logic that must be taken into account to fix.

{code:java}
                       // Line 699 intead of this
-                      if (type == Object.class && !(genericType instanceof Class)) {
                       // using the following
+                     if (type == Object.class && !(genericType instanceof Class)
+                                      || (genericType instanceof TypeVariable)) {
{code}


> Problem to generate WADL when a implementation of generic type is used
> ----------------------------------------------------------------------
>
>                 Key: CXF-7545
>                 URL: https://issues.apache.org/jira/browse/CXF-7545
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-RS
>    Affects Versions: 3.1.9, 3.2.0
>         Environment: All plataforms
>            Reporter: Evaristo Wychoski Benfatti
>            Assignee: Sergey Beryozkin
>            Priority: Minor
>              Labels: patch
>             Fix For: 3.1.14, 3.2.1
>
>
> When we have the following scenario, the the wadl is not properly generated.
> {code:java}
> public abstract class BaseEntity { ... }
> public class Entity extends BaseEntity { ... }
> public abstract class SuperResource<T extends BaseEntity>
> {
>     @POST
>     @Path("/method")
>     public T resourceMethod(T param){ ... }
> }
> @Path("/resource")
> public class ChildResource extends SuperResource<Entity> { ... }
> {code}
> The generation to ChildResource only exposes the methods to {{BaseEntity}} instead of exposing correctly the specialized type {{Entity}}.
> This problem occurs on {{rt/rs/description/src/main/java/org/apache/cxf/jaxrs/model/wadl/WadlGenerator.java}} file when it evaluates generic types. 
> The solution is considering the TypeVariable to specialized types as follow:
> {code:java}
>                 // Line 1047 instead of this
> -                if (theActualType == Object.class && !(genericType instanceof Class)) {
>                  // using the following lines
> +                if ((theActualType == Object.class && !(genericType instanceof Class))
> +					|| (genericType instanceof TypeVariable)) {
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)