You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by "B.J. Reed (JIRA)" <ji...@apache.org> on 2008/06/12 23:16:44 UTC

[jira] Created: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

should remove tags from source files that have no data
------------------------------------------------------

                 Key: GERONIMODEVTOOLS-395
                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
             Project: Geronimo-Devtools
          Issue Type: Sub-task
          Components: eclipse-plugin
    Affects Versions: 2.1.x
            Reporter: B.J. Reed
            Assignee: B.J. Reed
            Priority: Minor
             Fix For: 2.1.x


When using any of the deployment plan editors, setting a field to have nothing in it gives an XML tag with nothing in it. Before editing a plan, unnecessary tags are not shown in the deployment plan,  this is the state the plan should revert to.  For example:

If I use the editor to specify an application client call back handler, I will get a tag like this (which is good)

<client:callback-handler>aHandler</client:callback-handler>

Going back into the editor and removing that, I get 

<client:callback-handler></client:callback-handler>

I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim McConnell updated GERONIMODEVTOOLS-395:
-------------------------------------------

    Fix Version/s:     (was: 2.1.x)
                   2.1.2

> should remove tags from source files that have no data
> ------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-395
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.1.x
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.1.2
>
>
> When using any of the deployment plan editors, setting a field to have nothing in it gives an XML tag with nothing in it. Before editing a plan, unnecessary tags are not shown in the deployment plan,  this is the state the plan should revert to.  For example:
> If I use the editor to specify an application client call back handler, I will get a tag like this (which is good)
> <client:callback-handler>aHandler</client:callback-handler>
> Going back into the editor and removing that, I get 
> <client:callback-handler></client:callback-handler>
> I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim McConnell updated GERONIMODEVTOOLS-395:
-------------------------------------------

    Fix Version/s:     (was: 2.1.2)
                   2.1.3

> should remove tags from source files that have no data
> ------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-395
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.1.3
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.1.3
>
>         Attachments: GERONIMODEVTOOLS-395a.patch
>
>
> When using any of the deployment plan editors, setting a field to have nothing in it gives an XML tag with nothing in it. Before editing a plan, unnecessary tags are not shown in the deployment plan,  this is the state the plan should revert to.  For example:
> If I use the editor to specify an application client call back handler, I will get a tag like this (which is good)
> <client:callback-handler>aHandler</client:callback-handler>
> Going back into the editor and removing that, I get 
> <client:callback-handler></client:callback-handler>
> I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753404#action_12753404 ] 

Delos Dai commented on GERONIMODEVTOOLS-395:
--------------------------------------------

This JIRA is partly resovled. But there may be more empty elements can be removed, only if  the removing won't result in any deployment problem. We can remove one if we meet one.
So  keep this JIRA open for future tracking.

> should remove tags from source files that have no data
> ------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-395
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.1.3
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: GERONIMODEVTOOLS-395a.patch
>
>
> When using any of the deployment plan editors, setting a field to have nothing in it gives an XML tag with nothing in it. Before editing a plan, unnecessary tags are not shown in the deployment plan,  this is the state the plan should revert to.  For example:
> If I use the editor to specify an application client call back handler, I will get a tag like this (which is good)
> <client:callback-handler>aHandler</client:callback-handler>
> Going back into the editor and removing that, I get 
> <client:callback-handler></client:callback-handler>
> I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

Posted by "B.J. Reed (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12625749#action_12625749 ] 

B.J. Reed commented on GERONIMODEVTOOLS-395:
--------------------------------------------

3 more tags that can be removed by the deplyment plan editor when empty.
<dep:dependencies/>
<dep:hidden-classes/>
<dep:non-overridable-classes/>

> should remove tags from source files that have no data
> ------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-395
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.1.3
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.1.3
>
>         Attachments: GERONIMODEVTOOLS-395a.patch
>
>
> When using any of the deployment plan editors, setting a field to have nothing in it gives an XML tag with nothing in it. Before editing a plan, unnecessary tags are not shown in the deployment plan,  this is the state the plan should revert to.  For example:
> If I use the editor to specify an application client call back handler, I will get a tag like this (which is good)
> <client:callback-handler>aHandler</client:callback-handler>
> Going back into the editor and removing that, I get 
> <client:callback-handler></client:callback-handler>
> I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

Posted by "Tim McConnell (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12608934#action_12608934 ] 

Tim McConnell commented on GERONIMODEVTOOLS-395:
------------------------------------------------

Patch 395a works as specified and applied at revision 672410. Thanks BJ for the patch !!

> should remove tags from source files that have no data
> ------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-395
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.1.x
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.1.2
>
>         Attachments: GERONIMODEVTOOLS-395a.patch
>
>
> When using any of the deployment plan editors, setting a field to have nothing in it gives an XML tag with nothing in it. Before editing a plan, unnecessary tags are not shown in the deployment plan,  this is the state the plan should revert to.  For example:
> If I use the editor to specify an application client call back handler, I will get a tag like this (which is good)
> <client:callback-handler>aHandler</client:callback-handler>
> Going back into the editor and removing that, I get 
> <client:callback-handler></client:callback-handler>
> I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

Posted by "Ted Kirby (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Kirby updated GERONIMODEVTOOLS-395:
---------------------------------------

    Fix Version/s:     (was: 2.1.3)
                   2.2.0

> should remove tags from source files that have no data
> ------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-395
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.1.3
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.2.0
>
>         Attachments: GERONIMODEVTOOLS-395a.patch
>
>
> When using any of the deployment plan editors, setting a field to have nothing in it gives an XML tag with nothing in it. Before editing a plan, unnecessary tags are not shown in the deployment plan,  this is the state the plan should revert to.  For example:
> If I use the editor to specify an application client call back handler, I will get a tag like this (which is good)
> <client:callback-handler>aHandler</client:callback-handler>
> Going back into the editor and removing that, I get 
> <client:callback-handler></client:callback-handler>
> I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

Posted by "B.J. Reed (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

B.J. Reed updated GERONIMODEVTOOLS-395:
---------------------------------------

    Attachment: GERONIMODEVTOOLS-395a.patch

395a.patch covers most of the easier situations.  Still much work to be done after this, especially for things like when all objects have been removed from a List.

> should remove tags from source files that have no data
> ------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-395
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.1.x
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.1.2
>
>         Attachments: GERONIMODEVTOOLS-395a.patch
>
>
> When using any of the deployment plan editors, setting a field to have nothing in it gives an XML tag with nothing in it. Before editing a plan, unnecessary tags are not shown in the deployment plan,  this is the state the plan should revert to.  For example:
> If I use the editor to specify an application client call back handler, I will get a tag like this (which is good)
> <client:callback-handler>aHandler</client:callback-handler>
> Going back into the editor and removing that, I get 
> <client:callback-handler></client:callback-handler>
> I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (GERONIMODEVTOOLS-395) should remove tags from source files that have no data

Posted by "Delos Dai (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Delos Dai updated GERONIMODEVTOOLS-395:
---------------------------------------

    Fix Version/s:     (was: 2.2.0)
                   2.2.1

> should remove tags from source files that have no data
> ------------------------------------------------------
>
>                 Key: GERONIMODEVTOOLS-395
>                 URL: https://issues.apache.org/jira/browse/GERONIMODEVTOOLS-395
>             Project: Geronimo-Devtools
>          Issue Type: Sub-task
>          Components: eclipse-plugin
>    Affects Versions: 2.1.3
>            Reporter: B.J. Reed
>            Assignee: B.J. Reed
>            Priority: Minor
>             Fix For: 2.2.1
>
>         Attachments: GERONIMODEVTOOLS-395a.patch
>
>
> When using any of the deployment plan editors, setting a field to have nothing in it gives an XML tag with nothing in it. Before editing a plan, unnecessary tags are not shown in the deployment plan,  this is the state the plan should revert to.  For example:
> If I use the editor to specify an application client call back handler, I will get a tag like this (which is good)
> <client:callback-handler>aHandler</client:callback-handler>
> Going back into the editor and removing that, I get 
> <client:callback-handler></client:callback-handler>
> I was expecting the whole line to just be deleted.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.