[GitHub] [lucene] jtibshirani commented on a change in pull request #361: LUCENE-10147: ensure that KnnVectorQuery scores are positive

[GitBox <gi...@apache.org>]

jtibshirani commented on a change in pull request #361:
URL: https://github.com/apache/lucene/pull/361#discussion_r723760893



##########
File path: lucene/core/src/test/org/apache/lucene/search/TestKnnVectorQuery.java
##########
@@ -204,6 +207,64 @@ public void testScore() throws IOException {
     }
   }
 
+  public void testScoreDotProduct() throws IOException {

Review comment:
       It'd be nice to have a simple test that reproduces the negative score issue (using normalized vectors with some negative components).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org