You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@logging.apache.org by rg...@apache.org on 2018/07/22 17:21:57 UTC

[2/3] logging-log4j2 git commit: LOG4J2-2389 - ThrowableProxy was saving and retrieving cache entries using different keys.

LOG4J2-2389 - ThrowableProxy was saving and retrieving cache entries using different keys.


Project: http://git-wip-us.apache.org/repos/asf/logging-log4j2/repo
Commit: http://git-wip-us.apache.org/repos/asf/logging-log4j2/commit/6aa1e866
Tree: http://git-wip-us.apache.org/repos/asf/logging-log4j2/tree/6aa1e866
Diff: http://git-wip-us.apache.org/repos/asf/logging-log4j2/diff/6aa1e866

Branch: refs/heads/master
Commit: 6aa1e86602a3b7bf5a02891b6f6b05d3488dbcaa
Parents: 99f39d9
Author: Ralph Goers <rg...@apache.org>
Authored: Sun Jul 22 10:06:31 2018 -0700
Committer: Ralph Goers <rg...@apache.org>
Committed: Sun Jul 22 10:06:31 2018 -0700

----------------------------------------------------------------------
 .../java/org/apache/logging/log4j/core/impl/ThrowableProxy.java   | 2 +-
 src/changes/changes.xml                                           | 3 +++
 2 files changed, 4 insertions(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6aa1e866/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java
----------------------------------------------------------------------
diff --git a/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java b/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java
index fe557ad..111ff71 100644
--- a/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java
+++ b/log4j-core/src/main/java/org/apache/logging/log4j/core/impl/ThrowableProxy.java
@@ -738,7 +738,7 @@ public class ThrowableProxy implements Serializable {
                     final CacheEntry entry = this.toCacheEntry(stackTraceElement,
                         this.loadClass(lastLoader, className), false);
                     extClassInfo = entry.element;
-                    map.put(stackTraceElement.toString(), entry);
+                    map.put(className, entry);
                     if (entry.loader != null) {
                         lastLoader = entry.loader;
                     }

http://git-wip-us.apache.org/repos/asf/logging-log4j2/blob/6aa1e866/src/changes/changes.xml
----------------------------------------------------------------------
diff --git a/src/changes/changes.xml b/src/changes/changes.xml
index 584cafe..b637344 100644
--- a/src/changes/changes.xml
+++ b/src/changes/changes.xml
@@ -226,6 +226,9 @@
       </action>
     </release>
     <release version="2.11.1" date="2018-MM-DD" description="GA Release 2.11.1">
+      <action issue="LOG4J2-2389" dev="rgoers" type="fix" due-to="Liu Wen">
+        ThrowableProxy was saving and retrieving cache entries using different keys.
+      </action>
       <action issue="LOG4J2-2316" dev="rgoers" type="fix">
         If root LoggerConfig does not have a Level return ERROR.
       </action>