[GitHub] [ignite] ptupitsyn commented on a change in pull request #8795: IGNITE-14169 .NET: ForceJavaNamingConventions introduced

[GitBox <gi...@apache.org>]

ptupitsyn commented on a change in pull request #8795:
URL: https://github.com/apache/ignite/pull/8795#discussion_r575648961



##########
File path: modules/platforms/dotnet/Apache.Ignite.Core/Impl/Binary/TypeNameParser.cs
##########
@@ -30,19 +31,23 @@ internal class TypeNameParser
         private readonly int _start;
 
         /** */
-        private readonly string _typeName;
+        private char[] _typeNameArr;
+
+        /** */
+        private readonly bool _forceJavaNamingConventions;
 
         /** */
         private int _pos;
 
         /// <summary>
         /// Initializes a new instance of the <see cref="TypeNameParser" /> class.
         /// </summary>
-        private TypeNameParser(string typeName, ref int pos)
+        private TypeNameParser(string typeName, ref int pos, bool forceJavaNamingConventions)
         {
-            _typeName = typeName;
+            _typeNameArr = typeName.ToCharArray();
             _start = pos;
             _pos = _start;
+            _forceJavaNamingConventions = forceJavaNamingConventions;

Review comment:
       Separation of concerns: `TypeNameParser` should not care about `forceJavaNamingConventions`, it just parses the .NET type name. We should perform the `ToLower` call elsewhere.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org