You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/23 20:18:11 UTC
Review Request 71145: Fixed signature to pass parameter by const ref
instead of value.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71145/
-----------------------------------------------------------
Review request for mesos and Chun-Hung Hsiao.
Bugs: MESOS-9254
https://issues.apache.org/jira/browse/MESOS-9254
Repository: mesos
Description
-------
Fixed signature to pass parameter by const ref instead of value.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp 69861265d94ddf344da96b593797ce145394413e
Diff: https://reviews.apache.org/r/71145/diff/1/
Testing
-------
`make check`
Thanks,
Benjamin Bannier
Re: Review Request 71145: Fixed signature to pass parameter by const
ref instead of value.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71145/#review216874
-----------------------------------------------------------
Ship it!
Ship It!
- Chun-Hung Hsiao
On July 23, 2019, 8:18 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71145/
> -----------------------------------------------------------
>
> (Updated July 23, 2019, 8:18 p.m.)
>
>
> Review request for mesos and Chun-Hung Hsiao.
>
>
> Bugs: MESOS-9254
> https://issues.apache.org/jira/browse/MESOS-9254
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed signature to pass parameter by const ref instead of value.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp 69861265d94ddf344da96b593797ce145394413e
>
>
> Diff: https://reviews.apache.org/r/71145/diff/1/
>
>
> Testing
> -------
>
> `make check`
>
>
> Thanks,
>
> Benjamin Bannier
>
>