You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2022/03/01 12:21:34 UTC
[GitHub] [solr] radu-gheorghe opened a new pull request #714: Mention uniqueKey requirement for highlighting
radu-gheorghe opened a new pull request #714:
URL: https://github.com/apache/solr/pull/714
This one is hard to catch because there's no error if you set `hl=on` and there's no `uniqueKey`. You just don't see a `highlighting` element in the response.
I didn't think a Jira is required for this small change. I did test my changes with `./gradlew buildLocalSite` so the link to the schema page works.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh merged pull request #714: Mention uniqueKey requirement for highlighting
Posted by GitBox <gi...@apache.org>.
epugh merged pull request #714:
URL: https://github.com/apache/solr/pull/714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] radu-gheorghe commented on pull request #714: Mention uniqueKey requirement for highlighting
Posted by GitBox <gi...@apache.org>.
radu-gheorghe commented on pull request #714:
URL: https://github.com/apache/solr/pull/714#issuecomment-1056399599
@epugh yes, I think an error would be nice. I mean, if I ask for highlighting and it can't be done, I expect an error. But I guess that's a separate issue.
If `uniqueKey` isn't there, there's no trace of highlighting whatsoever. It's as if I didn't ask for it at all. And nothing in the logs (at least not with the default INFO level).
I'm not sure how to change the wording to "highlighting only works if you have a uniqueKey" - I suppose that wouldn't be in the parenthesis I added, but maybe in another spot? To be, the current wording is OK, but we can definitely change it if you prefer something else.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] radu-gheorghe commented on pull request #714: Mention uniqueKey requirement for highlighting
Posted by GitBox <gi...@apache.org>.
radu-gheorghe commented on pull request #714:
URL: https://github.com/apache/solr/pull/714#issuecomment-1059325821
Looks perfect to me. Thanks @epugh!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #714: Mention uniqueKey requirement for highlighting
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #714:
URL: https://github.com/apache/solr/pull/714#issuecomment-1059298851
@radu-gheorghe what do you think of this edit I made? If you like it, I can merge this, and if you don't, I can back it out!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #714: Mention uniqueKey requirement for highlighting
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #714:
URL: https://github.com/apache/solr/pull/714#issuecomment-1055707386
Out of curiosity, do you think an error message by solr should be thrown? I sort of wish there was a way to know when your query structure doesn't make sense....
I
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org
[GitHub] [solr] epugh commented on pull request #714: Mention uniqueKey requirement for highlighting
Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #714:
URL: https://github.com/apache/solr/pull/714#issuecomment-1055720237
what happens if you don't have a uniqueKey? I wonder if we need to change the wording to be "highlighting only works if you have a uniqueKey"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org