You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/02/24 15:54:57 UTC

[GitHub] [storm] Ethanlm commented on a change in pull request #3214: [MINOR] remove some unused fields and correct comment typo

Ethanlm commented on a change in pull request #3214: [MINOR] remove some unused fields and correct comment typo
URL: https://github.com/apache/storm/pull/3214#discussion_r383349852
 
 

 ##########
 File path: storm-server/src/test/java/org/apache/storm/scheduler/resource/strategies/priority/TestFIFOSchedulingPriorityStrategy.java
 ##########
 @@ -43,54 +43,52 @@
 
     @Test
     public void testFIFOEvictionStrategy() {
-        try (Time.SimulatedTime sim = new Time.SimulatedTime()) {
 
 Review comment:
   We might not want to delete this because it simulates the Time and saves time spending on unit test on some cases. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services