You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/12/14 00:06:58 UTC

[GitHub] [flink] bowenli86 opened a new pull request #10578: [FLINK-15254][sql cli][module] modules in SQL CLI yaml should preserve order

bowenli86 opened a new pull request #10578: [FLINK-15254][sql cli][module] modules in SQL CLI yaml should preserve order
URL: https://github.com/apache/flink/pull/10578
 
 
   ## What is the purpose of the change
   
   currently the module map is a hash map in sql cli, which doesn't preserve module loading order from yaml.
   fix it by always using a linked hash map
   
   ## Brief change log
   
   - always using a linked hash map in sql cli to handle module order
   - added UT
   
   ## Verifying this change
   
   This change added tests and can be verified as follows: `EnvironmentTest.testModuleOrder`
   
   ## Does this pull request potentially affect one of the following parts:
   
   n/a
   
   ## Documentation
   
   n/a

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services