[GitHub] [dubbo-go] wenxuwan commented on a change in pull request #985: Fix: consumer invoker cache set nil after the ZK connection is lost

[GitBox <gi...@apache.org>]

wenxuwan commented on a change in pull request #985:
URL: https://github.com/apache/dubbo-go/pull/985#discussion_r567774456



##########
File path: config/reference_config.go
##########
@@ -269,4 +274,5 @@ func (c *ReferenceConfig) postProcessConfig(url *common.URL) {
 	for _, p := range extension.GetConfigPostProcessors() {
 		p.PostProcessReferenceConfig(url)
 	}
+

Review comment:
       remove empty line.

##########
File path: remoting/zookeeper/facade.go
##########
@@ -82,6 +82,7 @@ LOOP:
 					break
 				}
 				failTimes++
+				logger.Warnf("ZK reconnect fail times %d", failTimes)

Review comment:
       logger.Warnf("ZK reconnect failed %d times" , failTimes)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org