You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/06/18 21:08:16 UTC
[GitHub] [airflow] msumit opened a new pull request #16523: Update docs on setting up SMTP
msumit opened a new pull request #16523:
URL: https://github.com/apache/airflow/pull/16523
Fixes https://github.com/apache/airflow/issues/16468
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] msumit merged pull request #16523: Update docs on setting up SMTP
Posted by GitBox <gi...@apache.org>.
msumit merged pull request #16523:
URL: https://github.com/apache/airflow/pull/16523
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #16523: Update docs on setting up SMTP
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #16523:
URL: https://github.com/apache/airflow/pull/16523#discussion_r654316048
##########
File path: docs/apache-airflow/howto/email-config.rst
##########
@@ -29,8 +29,11 @@ in the ``[email]`` section.
subject_template = /path/to/my_subject_template_file
html_content_template = /path/to/my_html_content_template_file
-To configure SMTP credentials, create a connection called ``smtp_default``, or
-choose a custom connection name and set it in ``email_conn_id``.
+To configure SMTP settings, checkout the :ref:`SMTP <config:smtp>` section in the standard configuration.
+If you do not want to store the SMTP credentials in the config or in the environment variables, you can create a
+connection called ``smtp_default``, or choose a custom connection name and set the ``email_conn_id`` with it's name in
+the configuration & store SMTP username-password in it. Other SMTP settings like host, port etc always gets picked up
+from the configuration only.
Review comment:
```suggestion
from the configuration only. The connection can be of any type (for example http).
```
##########
File path: docs/apache-airflow/howto/email-config.rst
##########
@@ -29,8 +29,11 @@ in the ``[email]`` section.
subject_template = /path/to/my_subject_template_file
html_content_template = /path/to/my_html_content_template_file
-To configure SMTP credentials, create a connection called ``smtp_default``, or
-choose a custom connection name and set it in ``email_conn_id``.
+To configure SMTP settings, checkout the :ref:`SMTP <config:smtp>` section in the standard configuration.
+If you do not want to store the SMTP credentials in the config or in the environment variables, you can create a
+connection called ``smtp_default``, or choose a custom connection name and set the ``email_conn_id`` with it's name in
+the configuration & store SMTP username-password in it. Other SMTP settings like host, port etc always gets picked up
+from the configuration only.
Review comment:
```suggestion
from the configuration only. The connection can be of any type (for example 'HTTP connection').
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #16523: Update docs on setting up SMTP
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #16523:
URL: https://github.com/apache/airflow/pull/16523#issuecomment-863929903
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org