[GitHub] [tvm] Hzfengsy commented on a change in pull request #8943: [TensorIR][M2a] Compute-At

[GitBox <gi...@apache.org>]

Hzfengsy commented on a change in pull request #8943:
URL: https://github.com/apache/tvm/pull/8943#discussion_r705019396



##########
File path: src/tir/schedule/primitive/cache_read_write.cc
##########
@@ -160,6 +160,21 @@ Block MakeCacheStage(const BufferRegion& cache_region, CacheStageInfo* info,
   return block;
 }
 
+/*!
+ * \brief Recalculate the `affine_binding` flag of the scope block info.
+ * \param block_sref The sref to the interested scope block.
+ */
+bool CalculateAffineFlag(const ScheduleState& self, const StmtSRef& block_sref) {
+  if (block_sref->parent == nullptr) {
+    return true;
+  }

Review comment:
       That's a good question. I think `affine flag` for opaque block makes no sense to me, no matter it's affine or not.
   Blocks with affine bindings have more schedule abilities than other blocks, while opaque blocks have no schedule abilities.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org