You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2020/12/02 07:04:11 UTC
[GitHub] [incubator-yunikorn-k8shim] wilfred-s opened a new pull request #210: [YUNIKORN-285] change lint sha detection
wilfred-s opened a new pull request #210:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/210
In a branch or PR the CI build has a limited history and often a
detached head. The lint sha detection does not work in all cases.
Adding detached head detection and changing the default reference for
the sha to HEAD^
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] kingamarton commented on a change in pull request #210: [YUNIKORN-285] change lint sha detection
Posted by GitBox <gi...@apache.org>.
kingamarton commented on a change in pull request #210:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/210#discussion_r534195792
##########
File path: Makefile
##########
@@ -70,6 +70,13 @@ all:
$(MAKE) -C $(dir $(BASE_DIR)) build
.PHONY: lint
+# Run lint against the previous commit for PR and branch build
+# In dev setup look at all changes on top of master
+REV := "HEAD^"
+DETACHED := $(findstring "fatal:", $(shell git symbolic-ref HEAD))
Review comment:
can git symbolic-ref have some fatal messages in case of some other errors than a detached head? I think it would be better to check the return status of git symbolic-ref, since it will return 1 if is not a symbolic ref, and 128 for some other errors.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] wilfred-s commented on a change in pull request #210: [YUNIKORN-285] change lint sha detection
Posted by GitBox <gi...@apache.org>.
wilfred-s commented on a change in pull request #210:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/210#discussion_r537187496
##########
File path: Makefile
##########
@@ -70,6 +70,13 @@ all:
$(MAKE) -C $(dir $(BASE_DIR)) build
.PHONY: lint
+# Run lint against the previous commit for PR and branch build
+# In dev setup look at all changes on top of master
+REV := "HEAD^"
+DETACHED := $(findstring "fatal:", $(shell git symbolic-ref HEAD))
Review comment:
Simplified the check, it did not work in all cases either...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] kingamarton closed pull request #210: [YUNIKORN-285] change lint sha detection
Posted by GitBox <gi...@apache.org>.
kingamarton closed pull request #210:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/210
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #210: [YUNIKORN-285] change lint sha detection
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #210:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/210#issuecomment-737041341
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=h1) Report
> Merging [#210](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=desc) (f467e2b) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/42e5a34a126587b5baac24e2a7f2886e0cbe87bd?el=desc) (42e5a34) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 58.29% 58.29%
=======================================
Files 33 33
Lines 2928 2928
=======================================
Hits 1707 1707
Misses 1149 1149
Partials 72 72
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=footer). Last update [42e5a34...2637db1](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] edited a comment on pull request #210: [YUNIKORN-285] change lint sha detection
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #210:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/210#issuecomment-737041341
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=h1) Report
> Merging [#210](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=desc) (2637db1) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/42e5a34a126587b5baac24e2a7f2886e0cbe87bd?el=desc) (42e5a34) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 58.29% 58.29%
=======================================
Files 33 33
Lines 2928 2928
=======================================
Hits 1707 1707
Misses 1149 1149
Partials 72 72
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=footer). Last update [42e5a34...2637db1](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-yunikorn-k8shim] codecov[bot] commented on pull request #210: [YUNIKORN-285] change lint sha detection
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #210:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/210#issuecomment-737041341
# [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=h1) Report
> Merging [#210](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=desc) (f467e2b) into [master](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/commit/42e5a34a126587b5baac24e2a7f2886e0cbe87bd?el=desc) (42e5a34) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #210 +/- ##
=======================================
Coverage 58.29% 58.29%
=======================================
Files 33 33
Lines 2928 2928
=======================================
Hits 1707 1707
Misses 1149 1149
Partials 72 72
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=footer). Last update [42e5a34...f467e2b](https://codecov.io/gh/apache/incubator-yunikorn-k8shim/pull/210?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org