You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Christian Müller (JIRA)" <ji...@apache.org> on 2010/04/16 19:20:25 UTC
[jira] Updated: (FELIX-2280) To much code duplication in
DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock
[ https://issues.apache.org/jira/browse/FELIX-2280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Christian Müller updated FELIX-2280:
------------------------------------
Attachment: FELIX-2280.patch
The attached patch provide the unit tests for these classes, the precondition for the refactoring...
It makes also 2 little changes in the existing implementations:
- I refactored 'System.currentTimeMillis()' in its own method to be able to test the generated sql statements
- I refactored 'Class.forName(driver); DriverManager.getConnection(url, username, password)' in its own method to be able to introduce the mock implemenations
Looking forward to work on the 'real' patch... :-)
> To much code duplication in DefaultJDBCLock, OracleJDBCLock and MySQLJDBCLock
> -----------------------------------------------------------------------------
>
> Key: FELIX-2280
> URL: https://issues.apache.org/jira/browse/FELIX-2280
> Project: Felix
> Issue Type: Improvement
> Components: Karaf
> Affects Versions: karaf-1.4.0
> Environment: All
> Reporter: Christian Müller
> Attachments: FELIX-2280.patch
>
>
> org.apache.felix.karaf.main.DefaultJDBCLock, org.apache.felix.karaf.main.MySQLJDBCLock and org.apache.felix.karaf.main.OracleJDBCLock has to much code duplications. I propose a solution like in ActiveMQ [package org.apache.activemq.store.jdbc.adapter|http://svn.apache.org/viewvc/activemq/trunk/activemq-core/src/main/java/org/apache/activemq/store/jdbc/adapter/].
> And we should implement some unit tests for it.
> If it's fine for you, I will try to improve this part of karaf and provide a patch for it.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira