[GitHub] [spark] beliefer commented on a change in pull request #34554: [SPARK-37286][SQL] Move compileAggregates from JDBCRDD to JdbcDialect

[GitBox <gi...@apache.org>]

beliefer commented on a change in pull request #34554:
URL: https://github.com/apache/spark/pull/34554#discussion_r761680072



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/jdbc/JDBCScanBuilder.scala
##########
@@ -72,7 +72,7 @@ case class JDBCScanBuilder(
     if (!jdbcOptions.pushDownAggregate) return false
 
     val dialect = JdbcDialects.get(jdbcOptions.url)
-    val compiledAgg = JDBCRDD.compileAggregates(aggregation.aggregateExpressions, dialect)
+    val compiledAgg = aggregation.aggregateExpressions.flatMap(dialect.compileAggregate(_))

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org