You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2019/10/14 08:29:33 UTC

[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull request #3251: fix #3213

terrymanu commented on a change in pull request #3251: fix #3213
URL: https://github.com/apache/incubator-shardingsphere/pull/3251#discussion_r334371035
 
 

 ##########
 File path: sharding-core/sharding-core-preprocessor/src/test/java/org/apache/shardingsphere/core/preprocessor/segment/select/projection/DerivedColumnTest.java
 ##########
 @@ -36,15 +36,15 @@ public void assertGetDerivedColumnAlias() {
     
     @Test
     public void assertIsDerivedColumn() {
-        assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_COUNT_0"));
-        assertTrue(DerivedColumn.isDerivedColumn("AVG_DERIVED_SUM_1"));
-        assertTrue(DerivedColumn.isDerivedColumn("ORDER_BY_DERIVED_0"));
-        assertTrue(DerivedColumn.isDerivedColumn("GROUP_BY_DERIVED_1"));
+        assertTrue(DerivedColumn.isDerivedColumnName("AVG_DERIVED_COUNT_0"));
+        assertTrue(DerivedColumn.isDerivedColumnName("AVG_DERIVED_SUM_1"));
+        assertTrue(DerivedColumn.isDerivedColumnName("ORDER_BY_DERIVED_0"));
+        assertTrue(DerivedColumn.isDerivedColumnName("GROUP_BY_DERIVED_1"));
     }
     
     @Test
     public void assertIsNotDerivedColumn() {
-        assertFalse(DerivedColumn.isDerivedColumn("OTHER_DERIVED_COLUMN_0"));
+        assertFalse(DerivedColumn.isDerivedColumnName("OTHER_DERIVED_COLUMN_0"));
 
 Review comment:
   Please refactor this test cases to make sure that  one method only have one test cases for same scenario.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services