You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "yin1999 (via GitHub)" <gi...@apache.org> on 2024/01/04 02:35:05 UTC
[PR] feat(generate): add go generate directive [dubbo-kubernetes]
yin1999 opened a new pull request, #136:
URL: https://github.com/apache/dubbo-kubernetes/pull/136
## What is the purpose of the change
Add go generate directive, as the embeded template is out of date. And it is necessary to provide automated commands for developers who are not familiar with the architecture.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(generate): add go generate directive [dubbo-kubernetes]
Posted by "yin1999 (via GitHub)" <gi...@apache.org>.
yin1999 commented on PR #136:
URL: https://github.com/apache/dubbo-kubernetes/pull/136#issuecomment-1876955031
Before merging this PR, please consider whether we should use the `go:embed` directive instead of the textual bytes array in go source file. Actually, as the bytes array has been compressed, it is difficult for us to read it directly. Storing it in text form does not bring any benefits and will increase the disk usage of the source code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(generate): add go generate directive [dubbo-kubernetes]
Posted by "yin1999 (via GitHub)" <gi...@apache.org>.
yin1999 commented on code in PR #136:
URL: https://github.com/apache/dubbo-kubernetes/pull/136#discussion_r1441213789
##########
generate/templates/main.go:
##########
@@ -61,7 +64,7 @@ func main() {
if err != nil {
log.Fatal(err)
}
- _, err = fmt.Fprintln(srcOut, "// Code generated by go generate; DO NOT EDIT.\npackage generate\n\nvar TemplatesZip = []byte{")
+ _, err = fmt.Fprint(srcOut, "// Code generated by go generate; DO NOT EDIT.\npackage generate\n\nvar TemplatesZip = []byte{")
Review Comment:
this previous function call left a empty line before the bytes array
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(generate): add go generate directive [dubbo-kubernetes]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #136:
URL: https://github.com/apache/dubbo-kubernetes/pull/136#issuecomment-1876759348
## [Codecov](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/136?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`c3ad915`)](https://app.codecov.io/gh/apache/dubbo-kubernetes/commit/c3ad915bd8b24e3f1f8b9c29a285e37c9a537ff5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.07% compared to head [(`cc3a64d`)](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/136?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 49.07%.
> :exclamation: Current head cc3a64d differs from pull request most recent head 8fe4ce1. Consider uploading reports for the commit 8fe4ce1 to get more accurate results
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #136 +/- ##
=======================================
Coverage 49.07% 49.07%
=======================================
Files 147 147
Lines 9457 9457
Branches 41 41
=======================================
Hits 4641 4641
Misses 4288 4288
Partials 528 528
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-kubernetes/pull/136?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] feat(generate): add go generate directive [dubbo-kubernetes]
Posted by "chickenlj (via GitHub)" <gi...@apache.org>.
chickenlj merged PR #136:
URL: https://github.com/apache/dubbo-kubernetes/pull/136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org