[GitHub] vanzin commented on a change in pull request #23838: [SPARK-26928][CORE] Add driver CPU Time to the metrics system

[GitBox <gi...@apache.org>]

vanzin commented on a change in pull request #23838: [SPARK-26928][CORE] Add driver CPU Time to the metrics system
URL: https://github.com/apache/spark/pull/23838#discussion_r260952399
 
 

 ##########
 File path: core/src/main/scala/org/apache/spark/SparkContext.scala
 ##########
 @@ -568,6 +569,10 @@ class SparkContext(config: SparkConf) extends Logging {
     _taskScheduler.postStartHook()
     _env.metricsSystem.registerSource(_dagScheduler.metricsSource)
     _env.metricsSystem.registerSource(new BlockManagerSource(_env.blockManager))
+    // Register JVMCPUSource to the metrics system if spark.metrics.cpu.time.driver.enabled==true
 
 Review comment:
   The comment just repeats the code.
   
   Why would you not enable this source? It seems to be always on for executors, what would be the drawback of doing the same for the driver?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org