You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "andpab (via GitHub)" <gi...@apache.org> on 2023/02/05 18:13:56 UTC
[GitHub] [maven-surefire] andpab opened a new pull request, #608: [SUREFIRE-2065] Fix parameterized JUnit4 test reporting
andpab opened a new pull request, #608:
URL: https://github.com/apache/maven-surefire/pull/608
This is an adjusted PR based on #516 from chalmagr.
I kept the additional ITs exactly as written by chalmagr.
The fix itself is different. It's less invasive, doesn't require making changes to the expectations of any expecting tests or ITs.
The root cause of the bug is that the logic for determining `hasParams` only looks at `methodSource.getMethodParameterTypes()`. That's not correct for JUnit 4 Parameterized tests since they do not have a method parameter. In JUnit 4 the parameterization is handled on a level further up.
The fix corrects the logic for determining `hasParams` so that it also works for JUnit4. It relies on the fact that for JUnit 4 parameterized tests there is a container-type test identifier with the legacyReportingName [<index>] or [<displayName>] that has an empty source field in the test identifier hierarchy - between the test method and the test class.
----
Following this checklist to help us incorporate your
contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] jbonofre commented on pull request #608: [SUREFIRE-2065] Fix parameterized JUnit4 test reporting
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #608:
URL: https://github.com/apache/maven-surefire/pull/608#issuecomment-1418232688
I'm reviewing and testing the PR. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] jbonofre commented on pull request #608: [SUREFIRE-2065] Fix parameterized JUnit4 test reporting
Posted by "jbonofre (via GitHub)" <gi...@apache.org>.
jbonofre commented on PR #608:
URL: https://github.com/apache/maven-surefire/pull/608#issuecomment-1418702474
@olamy ^^ can you please take a look and eventually merge ? A new surefire-plugin release would be great as well, I can prepare it if you want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-surefire] olamy merged pull request #608: [SUREFIRE-2065] Fix parameterized JUnit4 test reporting
Posted by "olamy (via GitHub)" <gi...@apache.org>.
olamy merged PR #608:
URL: https://github.com/apache/maven-surefire/pull/608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org