[GitHub] jerryjch opened a new pull request #23313: [SPARK-26315][PYSPARk] auto cast threshold from Integer to Float in approxSimilarityJoin of BucketedRandomProjectionLSHModel

[GitBox <gi...@apache.org>]

jerryjch opened a new pull request #23313: [SPARK-26315][PYSPARk] auto cast threshold from Integer to Float in approxSimilarityJoin of BucketedRandomProjectionLSHModel
URL: https://github.com/apache/spark/pull/23313
 
 
   
   ## What changes were proposed in this pull request?
   
   If the input parameter 'threshold' to the function approxSimilarityJoin is not a float, we would get an exception.  The fix is to convert the 'threshold' into a float before calling the java implementation method.
   
   ## How was this patch tested?
   
   Added a new test case.  Without this fix, the test will throw an exception as reported in the JIRA. With the fix, the test passes.
   
   Please review http://spark.apache.org/contributing.html before opening a pull request.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org