[Bug 65489] New: http condition followRedirects="false" doesn't work

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65489

            Bug ID: 65489
           Summary: http condition followRedirects="false" doesn't work
           Product: Ant
           Version: 1.10.10
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Core tasks
          Assignee: notifications@ant.apache.org
          Reporter: david-apache@shepherdson.name
  Target Milestone: ---

If you define a condition:

    <http url="https://someURL" followRedirects="false" />

...and it receives a redirect response, it will follow the redirection, rather
than stopping at that point.

This worked in versions before 1.10.10, but doesn't work (i.e. always follows
the redirection) in 1.10.10 and 1.10.11.

I believe this was caused by the changes for bug 65105. In the commit for that
issue:

https://github.com/apache/ant/commit/6dee37087/

...the new method redirectionAllowed() always returns true unconditionally at
the end when it isn't a protocol change. It seems like this should probably
return followRedirects instead.

For the time being, we've reverted to 1.10.9, and things are working as
expected.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 65489] http condition followRedirects="false" doesn't work

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65489

--- Comment #2 from David Shepherdson <da...@shepherdson.name> ---
Thank you for dealing with this so quickly, Jaikiran, and apologies that it has
taken me so long to get back to you. I've finally had a chance to try out the
nightly builds, and I can confirm that everything is working as expected again
(I tried with build #69 specifically).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 65489] http condition followRedirects="false" doesn't work

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65489

Jaikiran Pai <ja...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|---                         |1.10.12
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #1 from Jaikiran Pai <ja...@apache.org> ---
Hello David,

Thank you for raising this issue. This is indeed a bug. I've pushed a commit to
our master branch to fix this issue and the fix will be available in the next
release.

In the meantime, if you would like to try out this fix, then we publish our
nightly builds. You can get the last completed build from here
https://ci-builds.apache.org/job/Ant/job/Ant_Nightly/lastCompletedBuild/artifact/distribution/binaries/
and see how it goes (build number 65 or later should have this change).

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 65489] http condition followRedirects="false" doesn't work

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=65489

--- Comment #3 from Jaikiran Pai <ja...@apache.org> ---
Thank you for verifying the fix, David.

-- 
You are receiving this mail because:
You are the assignee for the bug.