[GitHub] [incubator-nuttx] acassis commented on a change in pull request #5408: drivers/syslog/syslog_device: fix flushing data when end of line is detected

[GitBox <gi...@apache.org>]

acassis commented on a change in pull request #5408:
URL: https://github.com/apache/incubator-nuttx/pull/5408#discussion_r798991604



##########
File path: drivers/syslog/syslog_device.c
##########
@@ -453,7 +453,7 @@ static ssize_t syslog_dev_write(FAR struct syslog_channel_s *channel,
         {
           /* Check for pre-formatted CR-LF sequence */
 
-          if (remaining > 1 &&
+          if (remaining > 2 &&

Review comment:
       Did you test without this modification? I think it basically means "if remaining equal 2 or higher", with this modification now it is "if remaing equal 3 or higher". So, imagine the case where remaining is equal 2 and it is exactly (rare but can happen) : "\r\n", this test will fail.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org