You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by ma...@apache.org on 2025/07/31 19:04:40 UTC
(superset) branch master updated: chore: Change button labels to sentence case (#34432)
This is an automated email from the ASF dual-hosted git repository.
maximebeauchemin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/superset.git
The following commit(s) were added to refs/heads/master by this push:
new ea64f3122e chore: Change button labels to sentence case (#34432)
ea64f3122e is described below
commit ea64f3122e2e5c8d6f9b67b4629020baa0053895
Author: Kasia <36...@users.noreply.github.com>
AuthorDate: Thu Jul 31 21:04:33 2025 +0200
chore: Change button labels to sentence case (#34432)
Co-authored-by: Claude <no...@anthropic.com>
---
.../nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx | 6 +++---
.../components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx | 4 ++--
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx
index 4511f5dc42..2c5cc0618c 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterConfigPane.test.tsx
@@ -96,14 +96,14 @@ test('remove filter', async () => {
test('add filter', async () => {
defaultRender();
// First trash icon
- const addFilterButton = await screen.findByText('Add Filter');
+ const addFilterButton = await screen.findByText('Add filter');
userEvent.click(addFilterButton);
expect(defaultProps.onAdd).toHaveBeenCalledWith('NATIVE_FILTER');
});
test('add divider', async () => {
defaultRender();
- const addFilterButton = await screen.findByText('Add Divider');
+ const addFilterButton = await screen.findByText('Add divider');
userEvent.click(addFilterButton);
expect(defaultProps.onAdd).toHaveBeenCalledWith('DIVIDER');
});
@@ -128,7 +128,7 @@ test('filter container should scroll to bottom when adding items', async () => {
defaultRender(state, props);
- const addFilterButton = await screen.findByText('Add Filter');
+ const addFilterButton = await screen.findByText('Add filter');
userEvent.click(addFilterButton);
diff --git a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx
index 8b1b32e017..f78bcfbc64 100644
--- a/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx
+++ b/superset-frontend/src/dashboard/components/nativeFilters/FiltersConfigModal/FilterTitlePane.tsx
@@ -111,7 +111,7 @@ const FilterTitlePane: FC<Props> = ({
data-test="add-new-filter-button"
onClick={() => handleOnAdd(NativeFilterType.NativeFilter)}
>
- {t('Add Filter')}
+ {t('Add filter')}
</Button>
<Button
buttonSize="default"
@@ -125,7 +125,7 @@ const FilterTitlePane: FC<Props> = ({
data-test="add-new-divider-button"
onClick={() => handleOnAdd(NativeFilterType.Divider)}
>
- {t('Add Divider')}
+ {t('Add divider')}
</Button>
</div>
</TabsContainer>