You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/04/09 17:53:41 UTC

[GitHub] [trafficcontrol] rob05c commented on a change in pull request #4621: Reduce Weasel exceptions

rob05c commented on a change in pull request #4621: Reduce Weasel exceptions
URL: https://github.com/apache/trafficcontrol/pull/4621#discussion_r406376267
 
 

 ##########
 File path: vendor/gopkg.in/fsnotify.v1/.gitignore
 ##########
 @@ -1,3 +1,20 @@
+# Licensed to the Apache Software Foundation (ASF) under one
 
 Review comment:
   Nope. Good catch. We shouldn't be touching vendored stuff, other people's code has its own licensing documentation in LICENSE.
   
   Moreover, touching vendored stuff runs the risk of creating a Derivative Work, which has its own legal and copyright implications and we may or may not have the rights to do. So we should avoid modifying files we don't own if at all possible.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services