[jira] [Commented] (WICKET-4032) ComponentStringResourceLoader must not include repeater items in resource lookup

["Nathan Messer (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13098146#comment-13098146 ] 

Nathan Messer commented on WICKET-4032:
---------------------------------------

Unfortunately that doesn't fix the problem. It excludes components with a parent of AbstractRepeater from the component stack, not the AbstractRepeaters themselves.

This then means that if it is the child of the abstract repeater which has the associated properties file, it won't get checked.

I've attached another quickstart showing the problem.

The patch I've submitted does handle this case as well, although it may be that there are other problems with it I'm not aware. For example the patch I submitted won't check if the AbstractRepeater itself has an associated properties file that may contain resources.

> ComponentStringResourceLoader must not include repeater items in resource lookup
> --------------------------------------------------------------------------------
>
>                 Key: WICKET-4032
>                 URL: https://issues.apache.org/jira/browse/WICKET-4032
>             Project: Wicket
>          Issue Type: Bug
>          Components: wicket
>    Affects Versions: 1.4.18
>            Reporter: Nathan Messer
>            Assignee: Peter Ertl
>             Fix For: 1.4.19
>
>         Attachments: resource-lookup.zip, resource-lookup2.zip, resourceloadingissue.patch, resourceloadingissue.patch
>
>
> Issue when using a StringResourceModel to lookup a resource for a component underneath a repeating view.
> When a StringResourceModel is used by a component under a repeating view, the ComponentStringResourceLoader doesn't find the resource.
> This seems to be a problem introduced by the fix for 3671.
> In ComponentStringResourceLoader, getResourcePath excludes all AbstractRepeaters, however getComponentStack doesn't leading to the two being out of sync for the elements of the component hierarchy under the repeating view.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira