You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/08/11 17:42:19 UTC
[GitHub] [netbeans] pepness commented on a diff in pull request #4454: Tomcat module cleanup
pepness commented on code in PR #4454:
URL: https://github.com/apache/netbeans/pull/4454#discussion_r943753570
##########
enterprise/tomcat5/src/org/netbeans/modules/tomcat5/ui/wizard/AddInstanceIterator.java:
##########
@@ -224,14 +224,14 @@ private void checkStartupScript(File homeDir) {
FileUtil.copyFile(
FileUtil.toFileObject(new File(bundledHome, "bin/" + CATALINA)), // NOI18N
FileUtil.toFileObject(new File(homeDir, "bin")), // NOI18N
- CATALINA.substring(0, CATALINA.indexOf(".")) // NOI18N
+ CATALINA.substring(0, CATALINA.indexOf('.')) // NOI18N
Review Comment:
You are right the difference should be negligible when it is patched.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists