You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by "Brett Porter (JIRA)" <ji...@codehaus.org> on 2005/05/26 09:47:21 UTC

[jira] Updated: (MPCHANGELOG-62) Inconsistent use of repositoryConnection and repositoryDeveloperConnectio

     [ http://jira.codehaus.org/browse/MPCHANGELOG-62?page=all ]

Brett Porter updated MPCHANGELOG-62:
------------------------------------

    Fix Version: 1.8
    Description: 
The scm plugin uses developerConnection and the repositoryConnection but the report plugins like changelog, file-activity, developer-activity perform the test the other way round.

The report plugins should use the scm plugin test order ...

        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.developerConnection}</echo>
          <j:set var="conn" value="${pom.repository.developerConnection}" />
        </j:if>
      </j:if>
                                                                                                      
      <j:if test="${conn == null}">
        <j:set var="value" value="${pom.repository.connection}"/>
        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.connection}</echo>
          <j:set var="conn" value="${pom.repository.connection}" />
        </j:if>
 
Not ....

          <j:set var="_connection">${pom.repository.connection}</j:set>
        <j:if test="${empty(_connection)}">
        <j:set var="_connection">${pom.repository.developerConnection}</j:set>
        </j:if>

  was:
The scm plugin uses developerConnection and the repositoryConnection but the report plugins like changelog, file-activity, developer-activity perform the test the other way round.

The report plugins should use the scm plugin test order ...

        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.developerConnection}</echo>
          <j:set var="conn" value="${pom.repository.developerConnection}" />
        </j:if>
      </j:if>
                                                                                                      
      <j:if test="${conn == null}">
        <j:set var="value" value="${pom.repository.connection}"/>
        <j:if test="${!empty(value)}">
          <echo>Using connection: ${pom.repository.connection}</echo>
          <j:set var="conn" value="${pom.repository.connection}" />
        </j:if>
 
Not ....

          <j:set var="_connection">${pom.repository.connection}</j:set>
        <j:if test="${empty(_connection)}">
        <j:set var="_connection">${pom.repository.developerConnection}</j:set>
        </j:if>


> Inconsistent use of repositoryConnection and repositoryDeveloperConnectio
> -------------------------------------------------------------------------
>
>          Key: MPCHANGELOG-62
>          URL: http://jira.codehaus.org/browse/MPCHANGELOG-62
>      Project: maven-changelog-plugin
>         Type: Bug
>  Environment: All
>     Reporter: Martin West
>      Fix For: 1.8

>
>
> The scm plugin uses developerConnection and the repositoryConnection but the report plugins like changelog, file-activity, developer-activity perform the test the other way round.
> The report plugins should use the scm plugin test order ...
>         <j:if test="${!empty(value)}">
>           <echo>Using connection: ${pom.repository.developerConnection}</echo>
>           <j:set var="conn" value="${pom.repository.developerConnection}" />
>         </j:if>
>       </j:if>
>                                                                                                       
>       <j:if test="${conn == null}">
>         <j:set var="value" value="${pom.repository.connection}"/>
>         <j:if test="${!empty(value)}">
>           <echo>Using connection: ${pom.repository.connection}</echo>
>           <j:set var="conn" value="${pom.repository.connection}" />
>         </j:if>
>  
> Not ....
>           <j:set var="_connection">${pom.repository.connection}</j:set>
>         <j:if test="${empty(_connection)}">
>         <j:set var="_connection">${pom.repository.developerConnection}</j:set>
>         </j:if>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see:
   http://www.atlassian.com/software/jira


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org