You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2023/04/06 13:23:19 UTC
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19706
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
IMPALA-12048: Add non-scan progress to queries webpage
This patch adds the non-scan progress of queries to Impala /queries
webpage. The non-scan progress indicates the completion progress
of a query's fragment instances that don't contain a scan node.
Testing:
- Add a new funtional test to test_web_pages.py.
Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M common/thrift/ExecStats.thrift
M tests/webserver/test_web_pages.py
M www/queries.tmpl
11 files changed, 103 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/19706/1
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19706
to look at the new patch set (#6).
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
IMPALA-12048: Add query progress to queries webpage
This patch adds the query progress of queries to Impala /queries
webpage. The query progress shows the completion progress of a
query's fragment instances. It helps users track the completion of
computation-intensive queries.
Testing:
- Added test cases to test_observability.py
- Added a new functional test to test_web_pages.py
Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M common/thrift/ExecStats.thrift
M tests/query_test/test_observability.py
M tests/webserver/test_web_pages.py
M www/queries.tmpl
13 files changed, 100 insertions(+), 31 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/19706/6
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 5: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9358/
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 29 May 2023 12:19:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9359/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 30 May 2023 07:45:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 9: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9403/
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 9
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Thu, 15 Jun 2023 15:18:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19706
to look at the new patch set (#7).
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
IMPALA-12048: Add query progress to queries webpage
This patch adds the query progress of queries to Impala /queries
webpage. The query progress shows the completion progress of a
query's fragment instances. It helps users track the completion of
computation-intensive queries.
Testing:
- Added test cases to test_observability.py
- Added a new functional test to test_web_pages.py
Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M common/thrift/ExecStats.thrift
M tests/query_test/test_observability.py
M tests/webserver/test_web_pages.py
M www/queries.tmpl
M www/query_detail_tabs.tmpl
14 files changed, 112 insertions(+), 39 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/19706/7
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 7
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19706
to look at the new patch set (#2).
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
IMPALA-12048: Add non-scan progress to queries webpage
This patch adds the non-scan progress of queries to Impala /queries
webpage. The non-scan progress indicates the completion progress
of a query's fragment instances that don't contain a scan node.
Testing:
- Add a new funtional test to test_web_pages.py.
Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M common/thrift/ExecStats.thrift
M tests/webserver/test_web_pages.py
M www/queries.tmpl
11 files changed, 103 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/19706/2
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 10: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 10
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 08:04:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Zihao Ye (Code Review)" <ge...@cloudera.org>.
Zihao Ye has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 6:
This new metric looks useful, should we also add it to the query detail page (query_detail_tabs.tmpl)?
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Thu, 01 Jun 2023 11:41:18 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
Patch Set 1:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/12758/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 06 Apr 2023 13:44:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9211/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Apr 2023 01:39:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12783/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 12 Apr 2023 12:51:12 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19706
to look at the new patch set (#3).
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
IMPALA-12048: Add non-scan progress to queries webpage
This patch adds the non-scan progress of queries to Impala /queries
webpage. The non-scan progress shows the completion progress of a
query's fragment instances that don't contain a scan node.
A sample output is attached to the IMPALA-12048 ticket.
Testing:
- Add a new funtional test to test_web_pages.py.
Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M common/thrift/ExecStats.thrift
M tests/webserver/test_web_pages.py
M www/queries.tmpl
11 files changed, 103 insertions(+), 24 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/19706/3
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13137/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 29 May 2023 07:13:48 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 10
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 26 Jun 2023 00:51:20 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 8:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19706/7/www/queries.tmpl
File www/queries.tmpl:
http://gerrit.cloudera.org:8080/#/c/19706/7/www/queries.tmpl@48
PS7, Line 48: <span title="{{tips_scan_progress}}">Scan Progress</span>
> To avoid the table become too wide, can we wrap these two progress strings
Done
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 8
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 07 Jun 2023 02:03:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19706/7/www/queries.tmpl
File www/queries.tmpl:
http://gerrit.cloudera.org:8080/#/c/19706/7/www/queries.tmpl@48
PS7, Line 48: <th title="{{tips_query_progress}}">Query Progress</th>
To avoid the table become too wide, can we wrap these two progress strings into one column? Just like what we did for "Duration / Queued Duration" and "Mem Usage / Mem Estimate".
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 7
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Tue, 06 Jun 2023 13:47:07 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
Patch Set 4:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9249/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 14:40:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19706
to look at the new patch set (#5).
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
IMPALA-12048: Add query progress to queries webpage
This patch adds the query progress of queries to Impala /queries
webpage. The query progress shows the completion progress of a
query's fragment instances. It helps users track the completion of
computation-intensive queries.
Testing:
- Add test cases to test_observability.py and test_web_pages.py
Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M common/thrift/ExecStats.thrift
M tests/query_test/test_observability.py
M tests/webserver/test_web_pages.py
M www/queries.tmpl
13 files changed, 101 insertions(+), 32 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/19706/5
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12762/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Apr 2023 07:58:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
Patch Set 4: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9249/
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 19:57:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Zihao Ye, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19706
to look at the new patch set (#8).
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
IMPALA-12048: Add query progress to queries webpage
This patch adds the query progress of queries to Impala /queries
webpage. The query progress shows the completion progress of a
query's fragment instances. It helps users track the completion of
computation-intensive queries.
Testing:
- Added test cases to test_observability.py
- Added a new functional test to test_web_pages.py
Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M common/thrift/ExecStats.thrift
M tests/query_test/test_observability.py
M tests/webserver/test_web_pages.py
M www/queries.tmpl
M www/query_detail_tabs.tmpl
14 files changed, 124 insertions(+), 45 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/19706/8
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 8
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 30 May 2023 13:02:33 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
IMPALA-12048: Add query progress to queries webpage
This patch adds the query progress of queries to Impala /queries
webpage. The query progress shows the completion progress of a
query's fragment instances. It helps users track the completion of
computation-intensive queries.
Testing:
- Added test cases to test_observability.py
- Added a new functional test to test_web_pages.py
Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Reviewed-on: http://gerrit.cloudera.org:8080/19706
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Quanlong Huang <hu...@gmail.com>
---
M be/src/runtime/coordinator-backend-state.cc
M be/src/runtime/coordinator-backend-state.h
M be/src/runtime/coordinator.cc
M be/src/runtime/coordinator.h
M be/src/service/impala-hs2-server.cc
M be/src/service/impala-http-handler.cc
M be/src/service/impala-http-handler.h
M be/src/service/impala-server.cc
M be/src/service/impala-server.h
M common/thrift/ExecStats.thrift
M tests/query_test/test_observability.py
M tests/webserver/test_web_pages.py
M www/queries.tmpl
M www/query_detail_tabs.tmpl
14 files changed, 124 insertions(+), 45 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Quanlong Huang: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 11
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 10:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9411/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 10
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 02:44:13 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13179/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 7
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 02 Jun 2023 09:50:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 6:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13140/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 30 May 2023 08:07:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 6:
> Patch Set 6:
>
> This new metric looks useful, should we also add it to the query detail page (query_detail_tabs.tmpl)?
Good idea! Thanks for the suggestion.
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 6
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Fri, 02 Jun 2023 09:26:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 5:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9358/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 5
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Mon, 29 May 2023 07:00:56 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 8:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/13215/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 8
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Wed, 07 Jun 2023 02:26:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 9:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9403/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 9
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Thu, 15 Jun 2023 09:50:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add query progress to queries webpage
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add query progress to queries webpage
......................................................................
Patch Set 10:
LGTM but there is a weird test failure:
https://jenkins.impala.io/job/ubuntu-16.04-from-scratch/19553/testReport/junit/webserver.test_web_pages/TestWebPage/test_query_progress/
webserver/test_web_pages.py:923: in test_query_progress
query, self.QUERIES_URL, expected_state=self.client.QUERY_STATES["RUNNING"])
webserver/test_web_pages.py:517: in __run_query_and_get_debug_page
query_handle = self.client.execute_async(query)
common/impala_connection.py:219: in execute_async
beeswax_handle = self.__beeswax_client.execute_query_async(sql_stmt, user=user)
beeswax/impala_beeswax.py:361: in execute_query_async
handle = self.__do_rpc(lambda: self.imp_service.query(query,))
beeswax/impala_beeswax.py:527: in __do_rpc
raise ImpalaBeeswaxException(self.__build_error_message(e), e)
E ImpalaBeeswaxException: ImpalaBeeswaxException:
E INNER EXCEPTION: <class 'thrift.transport.TTransport.TTransportException'>
E MESSAGE: TSocket read 0 bytes
It seems the query hasn't been submitted to Impala. It might be unrelated to this change. I just rebase the patch and rerun the test.
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 10
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Zihao Ye <ey...@163.com>
Gerrit-Comment-Date: Mon, 19 Jun 2023 02:43:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12048: Add non-scan progress to queries webpage
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19706 )
Change subject: IMPALA-12048: Add non-scan progress to queries webpage
......................................................................
Patch Set 1: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/9211/
--
To view, visit http://gerrit.cloudera.org:8080/19706
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e8695a8a8395c1364b4b249f83c4345d2cc53e
Gerrit-Change-Number: 19706
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 07 Apr 2023 06:56:17 +0000
Gerrit-HasComments: No