[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7752: NIFI-12041 Converted Groovy tests in nifi-scripting-bundle/nifi-scripting-processors to Java.

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory commented on code in PR #7752:
URL: https://github.com/apache/nifi/pull/7752#discussion_r1329261733


##########
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##########
@@ -120,28 +120,34 @@
             <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>org.apache.groovy</groupId>
+            <groupId>org.xmlunit</groupId>
+            <artifactId>xmlunit-core</artifactId>

Review Comment:
   Is this dependency required?



##########
nifi-nar-bundles/nifi-scripting-bundle/nifi-scripting-processors/pom.xml:
##########
@@ -120,28 +120,34 @@
             <scope>test</scope>
         </dependency>
         <dependency>
-            <groupId>org.apache.groovy</groupId>
+            <groupId>org.xmlunit</groupId>
+            <artifactId>xmlunit-core</artifactId>
+            <version>2.9.1</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.codehaus.groovy</groupId>
             <artifactId>groovy-json</artifactId>
-            <version>${nifi.groovy.version}</version>
+            <version>${scripting.groovy.version}</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
-            <groupId>org.apache.groovy</groupId>
+            <groupId>org.codehaus.groovy</groupId>
             <artifactId>groovy-jsr223</artifactId>
-            <version>${nifi.groovy.version}</version>
+            <version>${scripting.groovy.version}</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
-            <groupId>org.apache.groovy</groupId>
+            <groupId>org.codehaus.groovy</groupId>
             <artifactId>groovy-xml</artifactId>
-            <version>${nifi.groovy.version}</version>
+            <version>${scripting.groovy.version}</version>
             <scope>provided</scope>
         </dependency>
         <!-- groovy-all does not include groovy-dateutil by default, so must explicitly include it here -->
         <dependency>
-            <groupId>org.apache.groovy</groupId>
+            <groupId>org.codehaus.groovy</groupId>
             <artifactId>groovy-dateutil</artifactId>
-            <version>${nifi.groovy.version}</version>
+            <version>${scripting.groovy.version}</version>
         </dependency>

Review Comment:
   These package and version changes should be reverted to match the current main branch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org