You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by gs...@apache.org on 2022/09/26 17:15:36 UTC

[lucene] branch main updated: FacetsCollector#collect is no longer final to allow extension (#11804)

This is an automated email from the ASF dual-hosted git repository.

gsmiller pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/lucene.git


The following commit(s) were added to refs/heads/main by this push:
     new ac12cd9f176 FacetsCollector#collect is no longer final to allow extension (#11804)
ac12cd9f176 is described below

commit ac12cd9f176bf50bc80f1d7528f4c35d5ad22adf
Author: Greg Miller <gs...@gmail.com>
AuthorDate: Mon Sep 26 10:15:31 2022 -0700

    FacetsCollector#collect is no longer final to allow extension (#11804)
---
 lucene/CHANGES.txt                                                 | 2 ++
 lucene/facet/src/java/org/apache/lucene/facet/FacetsCollector.java | 2 +-
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/lucene/CHANGES.txt b/lucene/CHANGES.txt
index 85115c17011..ea22d302723 100644
--- a/lucene/CHANGES.txt
+++ b/lucene/CHANGES.txt
@@ -96,6 +96,8 @@ API Changes
 * GITHUB#11772: Removed native subproject and WindowsDirectory implementation from lucene.misc. Recommendation:
   use MMapDirectory implementation on Windows. (Robert Muir, Uwe Schindler, Dawid Weiss)
 
+* GITHUB#11804: FacetsCollector#collect is no longer final, allowing extension. (Greg Miller)
+
 Improvements
 ---------------------
 * GITHUB#11778: Detailed part-of-speech information for particle(조사) and ending(어미) on Nori
diff --git a/lucene/facet/src/java/org/apache/lucene/facet/FacetsCollector.java b/lucene/facet/src/java/org/apache/lucene/facet/FacetsCollector.java
index 78bf4b12623..cf49aef39ee 100644
--- a/lucene/facet/src/java/org/apache/lucene/facet/FacetsCollector.java
+++ b/lucene/facet/src/java/org/apache/lucene/facet/FacetsCollector.java
@@ -114,7 +114,7 @@ public class FacetsCollector extends SimpleCollector {
   }
 
   @Override
-  public final void collect(int doc) throws IOException {
+  public void collect(int doc) throws IOException {
     docsBuilder.grow(1).add(doc);
     if (keepScores) {
       if (totalHits >= scores.length) {