You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2013/12/11 09:30:04 UTC
Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test cases
for security group in advanced zone feature
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/
-----------------------------------------------------------
Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-2237
https://issues.apache.org/jira/browse/CLOUDSTACK-2237
Repository: cloudstack-git
Description
-------
Adding Automation tests for feature "Security Group Isolation in advanced zone".
@Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
Diffs
-----
test/integration/component/test_advancedsg_networks.py 4834351
tools/marvin/marvin/config/config.cfg PRE-CREATION
tools/marvin/marvin/configGenerator.py 6d5b70d
tools/marvin/marvin/integration/lib/base.py 86f962a
tools/marvin/marvin/integration/lib/common.py 096b073
Diff: https://reviews.apache.org/r/16178/diff/
Testing
-------
Tested locally on Advanced zone setup with security group enabled.
Thanks,
Ashutosh Kelkar
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30910
-----------------------------------------------------------
Ship it!
Committed the first patch to 4.3 and master.
- Girish Shilamkar
On Dec. 16, 2013, 10:01 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 10:01 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 4834351
> tools/marvin/marvin/config/config.cfg PRE-CREATION
> tools/marvin/marvin/configGenerator.py 6d5b70d
> tools/marvin/marvin/integration/lib/base.py b43af33
> tools/marvin/marvin/integration/lib/common.py 096b073
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review31116
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Dec. 27, 2013, 11:49 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 27, 2013, 11:49 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 7f3a390
> tools/marvin/marvin/config/config.cfg 5849fe8
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review32598
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Jan. 14, 2014, 8:51 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:51 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 7f3a390
> tools/marvin/marvin/config/config.cfg 5849fe8
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review31717
-----------------------------------------------------------
Commit c108d7f0d0e1e1e746dd186e3153c2d8387da7e2 in branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=c108d7f ]
CLOUDSTACK-2237: Automation-Adding next set of test cases for feature - SG in advanced zone
- ASF Subversion and Git Services
On Jan. 14, 2014, 8:51 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:51 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 7f3a390
> tools/marvin/marvin/config/config.cfg 5849fe8
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Girish Shilamkar <gi...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review31716
-----------------------------------------------------------
Ship it!
Ship It!
- Girish Shilamkar
On Jan. 14, 2014, 8:51 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Jan. 14, 2014, 8:51 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 7f3a390
> tools/marvin/marvin/config/config.cfg 5849fe8
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/
-----------------------------------------------------------
(Updated Jan. 14, 2014, 8:51 a.m.)
Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-2237
https://issues.apache.org/jira/browse/CLOUDSTACK-2237
Repository: cloudstack-git
Description
-------
Adding Automation tests for feature "Security Group Isolation in advanced zone".
@Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
Diffs (updated)
-----
test/integration/component/test_advancedsg_networks.py 7f3a390
tools/marvin/marvin/config/config.cfg 5849fe8
Diff: https://reviews.apache.org/r/16178/diff/
Testing
-------
Tested locally on Advanced zone setup with security group enabled.
Thanks,
Ashutosh Kelkar
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/
-----------------------------------------------------------
(Updated Dec. 27, 2013, 11:49 a.m.)
Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
Changes
-------
Adding next set of test cases.
Bugs: CLOUDSTACK-2237
https://issues.apache.org/jira/browse/CLOUDSTACK-2237
Repository: cloudstack-git
Description
-------
Adding Automation tests for feature "Security Group Isolation in advanced zone".
@Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
Diffs (updated)
-----
test/integration/component/test_advancedsg_networks.py 7f3a390
tools/marvin/marvin/config/config.cfg 5849fe8
Diff: https://reviews.apache.org/r/16178/diff/
Testing
-------
Tested locally on Advanced zone setup with security group enabled.
Thanks,
Ashutosh Kelkar
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30862
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Edukulla
On Dec. 16, 2013, 10:01 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 10:01 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 4834351
> tools/marvin/marvin/config/config.cfg PRE-CREATION
> tools/marvin/marvin/configGenerator.py 6d5b70d
> tools/marvin/marvin/integration/lib/base.py b43af33
> tools/marvin/marvin/integration/lib/common.py 096b073
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30909
-----------------------------------------------------------
Commit 4d9b95e13d9c59009cf359ab3c869e2bb48ba62f in branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=4d9b95e ]
CLOUDSTACK-2237: Automation - Adding new test cases for security group in advanced zone feature
- ASF Subversion and Git Services
On Dec. 16, 2013, 10:01 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 10:01 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 4834351
> tools/marvin/marvin/config/config.cfg PRE-CREATION
> tools/marvin/marvin/configGenerator.py 6d5b70d
> tools/marvin/marvin/integration/lib/base.py b43af33
> tools/marvin/marvin/integration/lib/common.py 096b073
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30908
-----------------------------------------------------------
Commit 029f4e36a0188520f46d7997df3e53ab1661fb63 in branch refs/heads/4.3 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=029f4e3 ]
CLOUDSTACK-2237: Automation - Adding new test cases for security group in advanced zone feature
- ASF Subversion and Git Services
On Dec. 16, 2013, 10:01 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 10:01 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 4834351
> tools/marvin/marvin/config/config.cfg PRE-CREATION
> tools/marvin/marvin/configGenerator.py 6d5b70d
> tools/marvin/marvin/integration/lib/base.py b43af33
> tools/marvin/marvin/integration/lib/common.py 096b073
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 10:01 a.m.)
Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
Bugs: CLOUDSTACK-2237
https://issues.apache.org/jira/browse/CLOUDSTACK-2237
Repository: cloudstack-git
Description
-------
Adding Automation tests for feature "Security Group Isolation in advanced zone".
@Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
Diffs (updated)
-----
test/integration/component/test_advancedsg_networks.py 4834351
tools/marvin/marvin/config/config.cfg PRE-CREATION
tools/marvin/marvin/configGenerator.py 6d5b70d
tools/marvin/marvin/integration/lib/base.py b43af33
tools/marvin/marvin/integration/lib/common.py 096b073
Diff: https://reviews.apache.org/r/16178/diff/
Testing
-------
Tested locally on Advanced zone setup with security group enabled.
Thanks,
Ashutosh Kelkar
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/
-----------------------------------------------------------
(Updated Dec. 16, 2013, 9:45 a.m.)
Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
Changes
-------
Review changes and added few more test cases.
Bugs: CLOUDSTACK-2237
https://issues.apache.org/jira/browse/CLOUDSTACK-2237
Repository: cloudstack-git
Description
-------
Adding Automation tests for feature "Security Group Isolation in advanced zone".
@Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
Diffs (updated)
-----
test/integration/component/test_advancedsg_networks.py 4834351
tools/marvin/marvin/config/config.cfg PRE-CREATION
tools/marvin/marvin/configGenerator.py 6d5b70d
tools/marvin/marvin/integration/lib/base.py b43af33
tools/marvin/marvin/integration/lib/common.py 096b073
Diff: https://reviews.apache.org/r/16178/diff/
Testing
-------
Tested locally on Advanced zone setup with security group enabled.
Thanks,
Ashutosh Kelkar
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Dec. 11, 2013, 6:04 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 376
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line376>
> >
> > Just verify the order of deletion. nwofferings or domain?
If we have domain specific networks, then domain removal does not remove the network in it (unlike in case of account), instead it throws exception while removing the domain, hence in cleanup, first networks are removed and then domain. And for network offering cleanup, order does not matter as long as network is removed before removing the offering.
> On Dec. 11, 2013, 6:04 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 512
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line512>
> >
> > Please follow proper spacing and lining
In RB it looks distorted because it cannot occupy the full horizontal width, I checked the spacing in py file, it is ok.
> On Dec. 11, 2013, 6:04 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 823
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line823>
> >
> > clean up with new way of list assertion
Sure will do that.
> On Dec. 11, 2013, 6:04 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/integration/lib/common.py, line 778
> > <https://reviews.apache.org/r/16178/diff/1/?file=396537#file396537line778>
> >
> > Whats the significance of this loop?
> > We are not taking any action based upon some matched\unmatched condition here.
> > We are either continuing or breaking but no action as what to do. Little unclear here.
Here we are storing the random vlan value in shared_ntwk_vlan, and if the value is present in already used vlans list, then we are going for another value (continue), and when we get such value which is not used by any of the existing network, we break the loop. I will change the code so that it is easier to understand.
> On Dec. 11, 2013, 6:04 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 340
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line340>
> >
> > Are we ok to raise for one deletion failure? we have other entities below for deletion.
I think we should just print the cleanup failures thorough debug, and if one of the cleanup has failed, then let's fail the test case after all the cleanups are done. What do you think?
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30203
-----------------------------------------------------------
On Dec. 11, 2013, 8:30 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 8:30 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 4834351
> tools/marvin/marvin/config/config.cfg PRE-CREATION
> tools/marvin/marvin/configGenerator.py 6d5b70d
> tools/marvin/marvin/integration/lib/base.py 86f962a
> tools/marvin/marvin/integration/lib/common.py 096b073
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Dec. 11, 2013, 6:04 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 1702
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line1702>
> >
> > There is no clean up i believe in case of an exception?
The important operations in test cases (Exactly what we are trying to test) such as shared network creation, vm creation are covered under try block and test cases are failed if exception is raised, but simpler operation like account creation do not need it IMO. In that case, we can cover whole test case under try block. What do you suggest?
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30203
-----------------------------------------------------------
On Dec. 16, 2013, 9:45 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 16, 2013, 9:45 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 4834351
> tools/marvin/marvin/config/config.cfg PRE-CREATION
> tools/marvin/marvin/configGenerator.py 6d5b70d
> tools/marvin/marvin/integration/lib/base.py b43af33
> tools/marvin/marvin/integration/lib/common.py 096b073
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30203
-----------------------------------------------------------
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57820>
Are we ok to raise for one deletion failure? we have other entities below for deletion.
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57819>
Just verify the order of deletion. nwofferings or domain?
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57817>
Please follow proper spacing and lining
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57818>
clean up with new way of list assertion
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57815>
There is no clean up i believe in case of an exception?
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/16178/#comment57814>
Whats the significance of this loop?
We are not taking any action based upon some matched\unmatched condition here.
We are either continuing or breaking but no action as what to do. Little unclear here.
- Santhosh Edukulla
On Dec. 11, 2013, 8:30 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 8:30 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 4834351
> tools/marvin/marvin/config/config.cfg PRE-CREATION
> tools/marvin/marvin/configGenerator.py 6d5b70d
> tools/marvin/marvin/integration/lib/base.py 86f962a
> tools/marvin/marvin/integration/lib/common.py 096b073
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Ashutosh Kelkar <as...@clogeny.com>.
> On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 340
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line340>
> >
> > Ideally, deletion failure is also a failure assuming CS was not able to delete it under some flow. But raising only if one entity failed and leaving others still may effect further flow\tests. If they try to create the entities with similar naming. May be dont raise and continue with further deletion and fail the test case. Here, the failure is not exactly a TC failure, but still can assume CS have a bug to delete.
Done
> On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote:
> > tools/marvin/marvin/integration/lib/common.py, line 778
> > <https://reviews.apache.org/r/16178/diff/1/?file=396537#file396537line778>
> >
> > But, if it is not there in the usedVlanIds, then breaking and doing what?
> >
> > If it is there we continue, at the end of this loop what we achieved? and the variable shared_ntwk_vlan variable is never used thereafter.
Shared_ntwk_vlan is returned from the function at the end. We search for the vlan id which is not in use (through the loop) and when we get it, we break, and we return.
> On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 1339
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line1339>
> >
> > Are we deleting the resources created here?
Every resource created in the test case has either added to cleanup, or deleted as part of the test case. There are no cleanup issues here. The purpose of the test case is to try to delete a shared network which is not in use.
> On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 1309
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line1309>
> >
> > We didnt deleted the resources created?
The resources are added to the cleanup list.
> On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 893
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line893>
> >
> > Is comment wrong here?
Yes, instead of "admin" account, it should be "user" account. Fixed this.
> On Dec. 12, 2013, 12:53 p.m., Santhosh Edukulla wrote:
> > test/integration/component/test_advancedsg_networks.py, line 1051
> > <https://reviews.apache.org/r/16178/diff/1/?file=396533#file396533line1051>
> >
> > Is there a failed criteria for this TC?
According to test plan, account specific shared networks with same subnet and vlan should get created in different accounts. But this is not happening right now. Further investigation needed to check if this is test case issue or product issue, hence skipped for now.
- Ashutosh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30255
-----------------------------------------------------------
On Dec. 11, 2013, 8:30 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 8:30 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 4834351
> tools/marvin/marvin/config/config.cfg PRE-CREATION
> tools/marvin/marvin/configGenerator.py 6d5b70d
> tools/marvin/marvin/integration/lib/base.py 86f962a
> tools/marvin/marvin/integration/lib/common.py 096b073
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 16178: CLOUDSTACK-2237: Automation - Adding new test
cases for security group in advanced zone feature
Posted by Santhosh Edukulla <sa...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16178/#review30255
-----------------------------------------------------------
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57922>
Ideally, deletion failure is also a failure assuming CS was not able to delete it under some flow. But raising only if one entity failed and leaving others still may effect further flow\tests. If they try to create the entities with similar naming. May be dont raise and continue with further deletion and fail the test case. Here, the failure is not exactly a TC failure, but still can assume CS have a bug to delete.
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57923>
Is comment wrong here?
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57924>
Is there a failed criteria for this TC?
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57925>
We didnt deleted the resources created?
test/integration/component/test_advancedsg_networks.py
<https://reviews.apache.org/r/16178/#comment57926>
Are we deleting the resources created here?
tools/marvin/marvin/integration/lib/common.py
<https://reviews.apache.org/r/16178/#comment57921>
But, if it is not there in the usedVlanIds, then breaking and doing what?
If it is there we continue, at the end of this loop what we achieved? and the variable shared_ntwk_vlan variable is never used thereafter.
- Santhosh Edukulla
On Dec. 11, 2013, 8:30 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16178/
> -----------------------------------------------------------
>
> (Updated Dec. 11, 2013, 8:30 a.m.)
>
>
> Review request for cloudstack, Girish Shilamkar, Santhosh Edukulla, and SrikanteswaraRao Talluri.
>
>
> Bugs: CLOUDSTACK-2237
> https://issues.apache.org/jira/browse/CLOUDSTACK-2237
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Adding Automation tests for feature "Security Group Isolation in advanced zone".
>
> @Santhosh: Please check the change in configGenerator file. Made changes to take relative path.
>
>
> Diffs
> -----
>
> test/integration/component/test_advancedsg_networks.py 4834351
> tools/marvin/marvin/config/config.cfg PRE-CREATION
> tools/marvin/marvin/configGenerator.py 6d5b70d
> tools/marvin/marvin/integration/lib/base.py 86f962a
> tools/marvin/marvin/integration/lib/common.py 096b073
>
> Diff: https://reviews.apache.org/r/16178/diff/
>
>
> Testing
> -------
>
> Tested locally on Advanced zone setup with security group enabled.
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>