You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@libcloud.apache.org by GitBox <gi...@apache.org> on 2020/01/14 13:55:36 UTC

[GitHub] [libcloud] c-w commented on a change in pull request #1408: Implement SAS URL generation for Azure Storage

c-w commented on a change in pull request #1408: Implement SAS URL generation for Azure Storage
URL: https://github.com/apache/libcloud/pull/1408#discussion_r366350129
 
 

 ##########
 File path: libcloud/storage/drivers/azure_blobs.py
 ##########
 @@ -489,6 +503,70 @@ def get_object(self, container_name, object_name):
         raise ObjectDoesNotExistError(value=None, driver=self,
                                       object_name=object_name)
 
+    def get_object_cdn_url(self, obj,
+                           ex_expiry=AZURE_STORAGE_CDN_URL_EXPIRY_HOURS):
 
 Review comment:
   I'll take a note to work on a follow-up PR with type annotations for the storage API.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services