You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2014/06/27 03:36:42 UTC
Review Request 23104: Added documentation for authorization.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23104/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Bugs: MESOS-1480
https://issues.apache.org/jira/browse/MESOS-1480
Repository: mesos-git
Description
-------
Let me know what you think.
Diffs
-----
docs/authorization.md PRE-CREATION
Diff: https://reviews.apache.org/r/23104/diff/
Testing
-------
Thanks,
Vinod Kone
Re: Review Request 23104: Added documentation for authorization.
Posted by Vinod Kone <vi...@gmail.com>.
> On June 27, 2014, 3:11 a.m., Dominic Hamon wrote:
> > docs/authorization.md, line 45
> > <https://reviews.apache.org/r/23104/diff/1/?file=619214#file619214line45>
> >
> > aside - should we have a different status for unauthorized launches? I'm worried about overloading the TASK_LOST status.
Yea thats not a bad idea. I think there is a TODO somewhere in the code to add more task statuses like TASK_ERROR/TASK_INVALID.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23104/#review46828
-----------------------------------------------------------
On June 27, 2014, 1:36 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23104/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 1:36 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1480
> https://issues.apache.org/jira/browse/MESOS-1480
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Let me know what you think.
>
>
> Diffs
> -----
>
> docs/authorization.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23104/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23104: Added documentation for authorization.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23104/#review46828
-----------------------------------------------------------
docs/authorization.md
<https://reviews.apache.org/r/23104/#comment82396>
aside - should we have a different status for unauthorized launches? I'm worried about overloading the TASK_LOST status.
docs/authorization.md
<https://reviews.apache.org/r/23104/#comment82397>
nit: s/ordered/order/
- Dominic Hamon
On June 26, 2014, 6:36 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23104/
> -----------------------------------------------------------
>
> (Updated June 26, 2014, 6:36 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1480
> https://issues.apache.org/jira/browse/MESOS-1480
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Let me know what you think.
>
>
> Diffs
> -----
>
> docs/authorization.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23104/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23104: Added documentation for authorization.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 11, 2014, 9:30 p.m., Bhuvan Arumugam wrote:
> > docs/authorization.md, line 38
> > <https://reviews.apache.org/r/23104/diff/2/?file=619935#file619935line38>
> >
> > Vinod, can you clarify the diff between "users" and "roles" objects? In framework like aurora, the "role" is the unix user that run the task on mesos slave. In this situation, how they are different?
>
> Vinod Kone wrote:
> Hey Bhuvan. The term "roles" refers to different things in Mesos and Aurora (and probably other frameworks). In Mesos, "roles" are tags used for "resources" and used in allocation. It has nothing to do with the unix user that is used to launch the task/executor.
>
> I would confirm with Aurora, but I think an Aurora 'role' maps to Mesos 'user'.
Also, FYI, the ACLs format of this yet-to-be-released feature has been updated recently. So, please make sure to check the updated doc at https://github.com/apache/mesos/blob/master/docs/authorization.md if you've already been using it.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23104/#review50236
-----------------------------------------------------------
On June 27, 2014, 9:52 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23104/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 9:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1480
> https://issues.apache.org/jira/browse/MESOS-1480
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Let me know what you think.
>
>
> Diffs
> -----
>
> docs/authorization.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23104/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23104: Added documentation for authorization.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 11, 2014, 9:30 p.m., Bhuvan Arumugam wrote:
> > docs/authorization.md, line 38
> > <https://reviews.apache.org/r/23104/diff/2/?file=619935#file619935line38>
> >
> > Vinod, can you clarify the diff between "users" and "roles" objects? In framework like aurora, the "role" is the unix user that run the task on mesos slave. In this situation, how they are different?
Hey Bhuvan. The term "roles" refers to different things in Mesos and Aurora (and probably other frameworks). In Mesos, "roles" are tags used for "resources" and used in allocation. It has nothing to do with the unix user that is used to launch the task/executor.
I would confirm with Aurora, but I think an Aurora 'role' maps to Mesos 'user'.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23104/#review50236
-----------------------------------------------------------
On June 27, 2014, 9:52 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23104/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 9:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1480
> https://issues.apache.org/jira/browse/MESOS-1480
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Let me know what you think.
>
>
> Diffs
> -----
>
> docs/authorization.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23104/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23104: Added documentation for authorization.
Posted by Bhuvan Arumugam <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23104/#review50236
-----------------------------------------------------------
docs/authorization.md
<https://reviews.apache.org/r/23104/#comment87886>
Vinod, can you clarify the diff between "users" and "roles" objects? In framework like aurora, the "role" is the unix user that run the task on mesos slave. In this situation, how they are different?
- Bhuvan Arumugam
On June 27, 2014, 9:52 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23104/
> -----------------------------------------------------------
>
> (Updated June 27, 2014, 9:52 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Bugs: MESOS-1480
> https://issues.apache.org/jira/browse/MESOS-1480
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Let me know what you think.
>
>
> Diffs
> -----
>
> docs/authorization.md PRE-CREATION
>
> Diff: https://reviews.apache.org/r/23104/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 23104: Added documentation for authorization.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23104/
-----------------------------------------------------------
(Updated June 27, 2014, 9:52 p.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
fixed typo. NNFR.
Bugs: MESOS-1480
https://issues.apache.org/jira/browse/MESOS-1480
Repository: mesos-git
Description
-------
Let me know what you think.
Diffs (updated)
-----
docs/authorization.md PRE-CREATION
Diff: https://reviews.apache.org/r/23104/diff/
Testing
-------
Thanks,
Vinod Kone