You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pdfbox.apache.org by paawak <gi...@git.apache.org> on 2018/04/28 22:57:43 UTC

[GitHub] pdfbox pull request #51: Bengali fix for GSUB: ja phala not rendering proper...

GitHub user paawak opened a pull request:

    https://github.com/apache/pdfbox/pull/51

    Bengali fix for GSUB: ja phala not rendering properly

    ![bengali-lohit-incorrect-ja-phala](https://user-images.githubusercontent.com/8063232/39401533-c9ea8018-4b64-11e8-86fa-b349bd21a62a.png)
    
    I had to get the "pstf" feature before "half" in the Gsub system for Bengali to fix this. I have also re-worked the BengaliPdfGenerationHelloWorld: added lot of text in there to verify that pdf-generation is good. In addition, I have also added the GSUBTablePrintUtil for printing out the compound characters in the Gsub Table.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/paawak/pdfbox paawak_ja_phala_bug_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/pdfbox/pull/51.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #51
    
----
commit 34013709580125d339393ba6cb3c89355ac769cc
Author: Palash Ray <pa...@...>
Date:   2018-04-25T10:53:58Z

    create the GsubWorkerFactory once for a given font, not for every word

commit 22875146c721392a87312e7ba10d3a72351ae03a
Author: Palash Ray <pa...@...>
Date:   2018-04-25T14:39:40Z

    added test for bengali copy paste

commit 1df17f2edae17a994e705385f46a1ba05fbb1fb3
Author: Palash Ray <pa...@...>
Date:   2018-04-26T06:24:33Z

    Merge remote-tracking branch 'upstream/trunk' into paawak_bengali_copy_paste

commit c1b7f3423e6d9148f1bcc16752f5899af0df366b
Author: Palash Ray <pa...@...>
Date:   2018-04-26T06:57:17Z

    Revert "create the GsubWorkerFactory once for a given font, not for every word"
    
    This reverts commit 34013709580125d339393ba6cb3c89355ac769cc.

commit e21beddbee1859b21b636101beaa5a6b1e8011f5
Author: Palash Ray <pa...@...>
Date:   2018-04-27T16:37:23Z

    Merge remote-tracking branch 'upstream/trunk' into paawak_bengali_copy_paste

commit 7de0225cf03565dc1321059750843cbaef0d6129
Author: Palash Ray <pa...@...>
Date:   2018-04-28T09:27:31Z

    Merge remote-tracking branch 'upstream/trunk' into paawak_bengali_copy_paste

commit 5118a0d86bb48af9f2b4bdb11ceed6ffcd78a999
Author: Palash Ray <pa...@...>
Date:   2018-04-28T10:58:16Z

    gsubtable debug util

commit 49cd04567700c46a09c39db2a93ea145463c44d0
Author: Palash Ray <pa...@...>
Date:   2018-04-28T11:32:31Z

    gsub debug util

commit b30379d29a803861e43dcec56c76b9ae4bb887d5
Author: Palash Ray <pa...@...>
Date:   2018-04-28T11:41:50Z

    javadocs

commit 4bedb1b9d4c9fd2189afcc46d46d8c80bb3573ef
Author: Palash Ray <pa...@...>
Date:   2018-04-28T17:39:48Z

    Merge remote-tracking branch 'upstream/trunk' into paawak_bengali_copy_paste

commit f04cf274c0dfa7b6926594e2525af0012de40fc3
Author: Palash Ray <pa...@...>
Date:   2018-04-28T20:10:09Z

    print util for gsub

commit f8052b01b4a47442954576478567b2cf55e29ebc
Author: Palash Ray <pa...@...>
Date:   2018-04-28T20:10:39Z

    minor debug changes

commit b2218c1fbc13d99097e446d0318ba3c6eb2ad1d2
Author: Palash Ray <pa...@...>
Date:   2018-04-28T20:11:40Z

    putting the "pstf" feature before "half" to solve the ja-phala not
    rendered problem

commit 956d395360628d956ccfb29a3908768a17fb1c44
Author: Palash Ray <pa...@...>
Date:   2018-04-28T20:13:13Z

    javadoc

commit 776fa5a9ef90f742117b459eade06cf1f8211e41
Author: Palash Ray <pa...@...>
Date:   2018-04-28T22:32:57Z

    re-wrote Bengali sample to print large amount of text: this helps us to
    know the correctness of the generated pdf

commit b7a2ea5775268b49d3572743d2282215956e6ef4
Author: Palash Ray <pa...@...>
Date:   2018-04-28T22:39:16Z

    Revert "added test for bengali copy paste"
    
    This reverts commit 22875146c721392a87312e7ba10d3a72351ae03a.

commit 3e730801d6386e192148e1d387eaa320129bdb54
Author: Palash Ray <pa...@...>
Date:   2018-04-28T22:56:49Z

    added authours

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org


[GitHub] pdfbox pull request #51: Bengali fix for GSUB: ja phala not rendering proper...

Posted by paawak <gi...@git.apache.org>.
Github user paawak closed the pull request at:

    https://github.com/apache/pdfbox/pull/51


---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pdfbox.apache.org
For additional commands, e-mail: dev-help@pdfbox.apache.org