You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by "divijvaidya (via GitHub)" <gi...@apache.org> on 2023/12/28 14:18:27 UTC

Re: [PR] KAFKA-16052: create a real dummy replicaManager instance to save memory [kafka]

divijvaidya commented on PR #15083:
URL: https://github.com/apache/kafka/pull/15083#issuecomment-1871218253

   Hey @showuon 
   There are multiple other things that need to be corrected with this test, such as closing metrics, ensuring that producePurgatory is being closed etc. Also, the change you proposed does not reset the mock of LogManager after every test. Hence, I have taken the liberty of creating a commit with a bunch of more changes: https://github.com/divijvaidya/kafka/commit/d4228a339035d83225408e5651e5cacbf604f0e8 
   
   Please feel free to implement the changes in this PR or cherry-pick the commit in this PR. Whatever is convenient for you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org