You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by li...@apache.org on 2019/01/09 06:09:25 UTC

[servicecomb-java-chassis] branch master updated: [SCB-1105] NoRouteToHostException, should allow all error message

This is an automated email from the ASF dual-hosted git repository.

liubao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/servicecomb-java-chassis.git


The following commit(s) were added to refs/heads/master by this push:
     new 5f618ab  [SCB-1105] NoRouteToHostException, should allow all error message
5f618ab is described below

commit 5f618abcac6a4cd1bf938b814a7d9fe9c1137c12
Author: weichao666 <we...@huawei.com>
AuthorDate: Tue Jan 8 21:36:23 2019 +0800

    [SCB-1105] NoRouteToHostException, should allow all error message
---
 .../apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java | 2 +-
 .../org/apache/servicecomb/loadbalance/TestDefaultRetryhandler.java   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
index f8ab374..1f1926f 100644
--- a/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
+++ b/handlers/handler-loadbalance/src/main/java/org/apache/servicecomb/loadbalance/DefaultRetryExtensionsFactory.java
@@ -55,7 +55,7 @@ public class DefaultRetryExtensionsFactory implements ExtensionsFactory {
            */
           .put(IOException.class, Arrays.asList(new String[] {"Connection reset by peer"}))
           .put(VertxException.class, Arrays.asList(new String[] {"Connection was closed"}))
-          .put(NoRouteToHostException.class, Arrays.asList(new String[]{"Host is unreachable"}))
+          .put(NoRouteToHostException.class, Arrays.asList())
           .build();
 
   @Override
diff --git a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestDefaultRetryhandler.java b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestDefaultRetryhandler.java
index 99faf1e..b0bd4ab 100644
--- a/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestDefaultRetryhandler.java
+++ b/handlers/handler-loadbalance/src/test/java/org/apache/servicecomb/loadbalance/TestDefaultRetryhandler.java
@@ -94,10 +94,10 @@ public class TestDefaultRetryhandler {
     boolean retriable = retryHandler.isRetriableException(root, false);
     Assert.assertTrue(retriable);
 
-    target = new NoRouteToHostException("Cannot assign requested address");
+    target = new NoRouteToHostException("No route to host");
     root = new Exception(target);
     retriable = retryHandler.isRetriableException(root, false);
-    Assert.assertFalse(retriable);
+    Assert.assertTrue(retriable);
   }
 
   @Test